From: Galen Charlton <gmc@equinoxinitiative.org>
Date: Fri, 6 Dec 2019 15:48:59 +0000 (-0500)
Subject: LP#1855457: make grid headers in Angular admin interfaces sticky
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=c6061319a9cf3f157a49a572aae76b7c43bbb6dd;p=working%2FEvergreen.git

LP#1855457: make grid headers in Angular admin interfaces sticky

Grid headers in Angular admininstration interfaces that use
subclass, or copy from AdminPageComponent are now sticky.

To test
-------
[1] Apply the patch and examine Angular admin pages that are
    are based on AdminPageComponent. A good example is the
    MARC Search/Facet Fields server admin page.
[2] Make the grid display a large number of rows, then scroll
    the page. Verify that the grid header is sticky (i.e.,
    the header remains visible in the viewport).
[3] Verify that the Carousels and Standing Penalties local admin
    grids have stick headers.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
---

diff --git a/Open-ILS/src/eg2/src/app/staff/admin/local/admin-carousel.component.html b/Open-ILS/src/eg2/src/app/staff/admin/local/admin-carousel.component.html
index 6740171a14..f1cedc7f3a 100644
--- a/Open-ILS/src/eg2/src/app/staff/admin/local/admin-carousel.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/admin/local/admin-carousel.component.html
@@ -41,7 +41,8 @@
 <eg-translate #translator></eg-translate>
 
 <eg-grid #grid idlClass="{{idlClass}}" [dataSource]="dataSource" 
-    [sortable]="true" persistKey="{{persistKey}}">
+    [sortable]="true" persistKey="{{persistKey}}"
+    [stickyHeader]="true">
   <eg-grid-toolbar-button [disabled]="!canCreate" 
     label="New {{idlClassDef.label}}" i18n-label [action]="createNew">
   </eg-grid-toolbar-button>
diff --git a/Open-ILS/src/eg2/src/app/staff/admin/local/standing-penalty.component.html b/Open-ILS/src/eg2/src/app/staff/admin/local/standing-penalty.component.html
index aefc58d640..a4e70d8ca3 100644
--- a/Open-ILS/src/eg2/src/app/staff/admin/local/standing-penalty.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/admin/local/standing-penalty.component.html
@@ -16,7 +16,7 @@
     [rowFlairIsEnabled]="true"
     [rowFlairCallback]="cspRowFlairCallback"
     [cellClassCallback]="cspGridCellClassCallback"
-    [sortable]="true">
+    [sortable]="true" [stickyHeader]="true">
     <eg-grid-toolbar-button 
       label="New Standing Penalty Type" i18n-label (onClick)="createNew()">
     </eg-grid-toolbar-button>
diff --git a/Open-ILS/src/eg2/src/app/staff/share/admin-page/admin-page.component.html b/Open-ILS/src/eg2/src/app/staff/share/admin-page/admin-page.component.html
index ceb9cbc001..215161f48d 100644
--- a/Open-ILS/src/eg2/src/app/staff/share/admin-page/admin-page.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/share/admin-page/admin-page.component.html
@@ -53,7 +53,8 @@
 </ng-template>
 
 <eg-grid #grid idlClass="{{idlClass}}" [dataSource]="dataSource" hideFields="{{hideGridFields}}"
-    [sortable]="true" persistKey="{{persistKey}}">
+    [sortable]="true" persistKey="{{persistKey}}"
+    [stickyHeader]="true">
   <eg-grid-toolbar-button [disabled]="!canCreate" 
     label="New {{idlClassDef.label}}" i18n-label (onClick)="createNew()">
   </eg-grid-toolbar-button>