From: Bill Erickson <berickxx@gmail.com>
Date: Wed, 15 Nov 2017 17:56:13 +0000 (-0500)
Subject: JBAS-1728 SCKO Renew failure hides count
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=c86be9ecf7f9b60253991e732ab9f9a5c5e243ff;p=working%2FEvergreen.git

JBAS-1728 SCKO Renew failure hides count

Avoid showing the count of failed renewals.  Show instead a generic
"Some items failed to renew" message.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
---

diff --git a/Open-ILS/web/js/dojo/openils/circ/nls/selfcheck.js b/Open-ILS/web/js/dojo/openils/circ/nls/selfcheck.js
index d394b5838f..0a9f2f1823 100644
--- a/Open-ILS/web/js/dojo/openils/circ/nls/selfcheck.js
+++ b/Open-ILS/web/js/dojo/openils/circ/nls/selfcheck.js
@@ -12,7 +12,7 @@
     "OPEN_CIRCULATION_EXISTS" : "Item ${0} is already checked out to another user",
     "GENERIC_CIRC_FAILURE" : "Unable to process some items. Please see staff.",
     "BATCH_RENEW_SUCCESS" : "Successfully renewed ${0} items",
-    "BATCH_RENEW_FAILURE" : "Failed to renew ${0} item(s).  Please see staff.",
+    "BATCH_RENEW_FAILURE" : "Some items failed to renew.  Please see staff.",
     "LOGIN_FAILED" : "Login for ${0} failed",
     "LOGIN_BARCODE_DOUBLE" : "Your PIN is needed.",
     "UNKNOWN_ERROR" : "An unhandled exception occurred with error code ${0}",
diff --git a/Open-ILS/web/js/ui/kcls/circ/selfcheck/selfcheck.js b/Open-ILS/web/js/ui/kcls/circ/selfcheck/selfcheck.js
index 76581c71ac..22cbbc90dd 100644
--- a/Open-ILS/web/js/ui/kcls/circ/selfcheck/selfcheck.js
+++ b/Open-ILS/web/js/ui/kcls/circ/selfcheck/selfcheck.js
@@ -750,8 +750,7 @@ SelfCheckManager.prototype.renewItems = function() {
     var sound = 'checkout-success';
 
     if (success_count < renew_count) {
-        msg = dojo.string.substitute(
-            localeStrings.BATCH_RENEW_FAILURE, [renew_count - success_count]);
+        msg = dojo.string.substitute(localeStrings.BATCH_RENEW_FAILURE);
         sound = 'checkout-failure';
     }