From: Jason Stephenson <jason@sigio.com>
Date: Wed, 13 Mar 2019 16:37:23 +0000 (-0400)
Subject: LP 1819796: Fix method call on undefined value in generate_fines.
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=c97839c9b49fbc5a0ae0bed424cef912073e6f54;p=working%2FEvergreen.git

LP 1819796: Fix method call on undefined value in generate_fines.

The below message repeats in the open-ils.storage_stderr.log:

Caught error from 'run' method: Can't call method "search_where" on an
undefined value at
/usr/local/share/perl/5.26.1/OpenILS/Application/Storage/Publisher/action.pm
line 1014.

This commit removes an errant ->search_where on a CStoreEditor call to
make that message go away.

Signed-off-by: Jason Stephenson <jason@sigio.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
index afb508ed67..9576b16f70 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
@@ -1011,7 +1011,7 @@ sub generate_fines {
 #        $circs = [$circ] if ($circ);
         $circs = $editor->search_action_circulation( { id => $circ_id, stop_fines => undef } );
         unless (@$circs) {
-            $circs = $editor->search_booking_reservation->search_where( { id => $circ_id, return_time => undef, cancel_time => undef } );
+            $circs = $editor->search_booking_reservation( { id => $circ_id, return_time => undef, cancel_time => undef } );
         }
     } else {
         $circs = [overdue_circs(undef, 1, 1, 1)];