From: Thomas Berezansky <tsbere@mvlc.org>
Date: Thu, 22 Sep 2011 13:16:31 +0000 (-0400)
Subject: Don't check barcode without strict enabled
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=ca4ab76a356eca4d2043631d4d8c730f04f95f6d;p=contrib%2FConifer.git

Don't check barcode without strict enabled

Item status was, unlike other interfaces, doing the strict check, THEN
looking at the checkbox and if it was checked return.

This caused issues when the barcode crashes out the strict checking.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
---

diff --git a/Open-ILS/xul/staff_client/server/circ/copy_status.js b/Open-ILS/xul/staff_client/server/circ/copy_status.js
index 510d13ce50..89e6287657 100644
--- a/Open-ILS/xul/staff_client/server/circ/copy_status.js
+++ b/Open-ILS/xul/staff_client/server/circ/copy_status.js
@@ -1107,9 +1107,9 @@ circ.copy_status.prototype = {
 
     'test_barcode' : function(bc) {
         var obj = this;
-        var good = util.barcode.check(bc);
         var x = document.getElementById('strict_barcode');
         if (x && x.checked != true) { return true; }
+        var good = util.barcode.check(bc);
         if (good) {
             return true;
         } else {