From: Jane Sandberg <sandbej@linnbenton.edu>
Date: Sat, 27 Jul 2019 17:50:40 +0000 (-0700)
Subject: LP1831785 (follow-up): simplifying static string binding, removing empty else statement
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=cb6efeb8261a50f101a40fa9d96268a937636e39;p=evergreen%2Fmasslnc.git

LP1831785 (follow-up): simplifying static string binding, removing empty else statement

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
---

diff --git a/Open-ILS/src/eg2/src/app/share/combobox/combobox.component.ts b/Open-ILS/src/eg2/src/app/share/combobox/combobox.component.ts
index 4a98fe39f6..1fe37b141b 100644
--- a/Open-ILS/src/eg2/src/app/share/combobox/combobox.component.ts
+++ b/Open-ILS/src/eg2/src/app/share/combobox/combobox.component.ts
@@ -223,7 +223,6 @@ export class ComboboxComponent implements OnInit {
         searchTerm = term;
         if (searchTerm === '_CLICK_' && this.asyncSupportsEmptyTermClick) {
             searchTerm = '';
-        } else {
         }
 
         return new Observable(observer => {
diff --git a/Open-ILS/src/eg2/src/app/staff/sandbox/sandbox.component.html b/Open-ILS/src/eg2/src/app/staff/sandbox/sandbox.component.html
index d7cff9f0d9..1b36ec8f60 100644
--- a/Open-ILS/src/eg2/src/app/staff/sandbox/sandbox.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/sandbox/sandbox.component.html
@@ -90,11 +90,11 @@
   <div class="col-lg-4">
   </div>
   <div class="col-lg-3">
-    <eg-combobox placeholder="Combobox with @idlClass = 'aou' @idlField='shortname'" [idlClass]="'aou'" [idlField]="'shortname'" [asyncSupportsEmptyTermClick]="true">
+    <eg-combobox placeholder="Combobox with @idlClass = 'aou' @idlField='shortname'" idlClass="aou" idlField="shortname" [asyncSupportsEmptyTermClick]="true">
     </eg-combobox>
   </div>
   <div class="col-lg-3">
-    <eg-combobox placeholder="Combobox with @idlClass = 'csp'" [idlClass]="'csp'" [asyncSupportsEmptyTermClick]="true">
+    <eg-combobox placeholder="Combobox with @idlClass = 'csp'" idlClass="csp" [asyncSupportsEmptyTermClick]="true">
     </eg-combobox>
   </div>
 </div>
@@ -102,7 +102,7 @@
   <div class="col-lg-4">
   </div>
   <div class="col-lg-3">
-    <eg-combobox placeholder="Combobox with @idlClass = 'aou'" [idlClass]="'aou'" [asyncSupportsEmptyTermClick]="true">
+    <eg-combobox placeholder="Combobox with @idlClass = 'aou'" idlClass="aou" [asyncSupportsEmptyTermClick]="true">
     </eg-combobox>
   </div>
   <div class="col-lg-3">