From: Dan Scott <dscott@laurentian.ca>
Date: Thu, 18 Jun 2015 15:52:00 +0000 (-0400)
Subject: LP#1409055 Support specific protocols for OpenSRF gateway requests
X-Git-Tag: osrf_rel_2_4_1~9^2
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=cc1f6ee9349584f7ec7b6f16861805a43f7161d6;p=OpenSRF.git

LP#1409055 Support specific protocols for OpenSRF gateway requests

If the user passes in a gateway hostname that contains a specific HTTP or HTTPS
protocol, let's just use that.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
---

diff --git a/src/python/osrf/gateway.py b/src/python/osrf/gateway.py
index eda1139..8796ce2 100644
--- a/src/python/osrf/gateway.py
+++ b/src/python/osrf/gateway.py
@@ -50,6 +50,18 @@ class GatewayRequest:
     setDefaultHost = staticmethod(setDefaultHost)
 
     def buildURL(self):
+        """
+        Builds the URL for the OpenSRF gateway based on the host and path
+
+        Previous versions of the code assumed that the host would be a bare
+        hostname or IP address, and prepended the http:// protocol. However,
+        to enable more secure communications, now we check for the existence
+        of the HTTP or HTTPS prefix and use that if it has been supplied.
+        """
+
+        if defaultHost.lower().startswith(('http://', 'https://')):
+            return '%s/%s' % (defaultHost, self.path)
+
         return 'http://%s/%s' % (defaultHost, self.path)
 
 class JSONGatewayRequest(GatewayRequest):