From: Bill Erickson <berick@esilibrary.com>
Date: Mon, 16 Jul 2012 20:56:10 +0000 (-0400)
Subject: Squelch uninitialized var warning from hold_copy_targeter
X-Git-Tag: sprint4-merge-nov22~4105
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=cde5d7218d4b6cfa782257cf488a1a317542fa13;p=working%2FEvergreen.git

Squelch uninitialized var warning from hold_copy_targeter

open-ils.storage_stderr.log was getting filled with entries like:

"Use of uninitialized value in concatenation (.) or string at
/usr/local/share/perl/5.10.1/OpenILS/Application/Storage/Publisher/action.pm"

... consuming disk space endlessly. Stop that!

(Stealing Lebbeous' footwork and providing a slightly different solution.)

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
index 7c07e6f188..ada8dc4df2 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
@@ -1285,7 +1285,7 @@ sub new_hold_copy_targeter {
 			my @good_copies;
 			for my $c (@$all_copies) {
 				# current target
-				next if ($c->id eq $hold->current_copy);
+				next if ($hold->current_copy and $c->id eq $hold->current_copy);
 
 				# skip on circ lib is closed IFF we care
 				my $ignore_closing;