From: Steven Callender <stevecallender@esilibrary.com>
Date: Tue, 24 Mar 2020 17:10:57 +0000 (-0400)
Subject: Change hold targeter to not pull out the pickup lib.
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=d29289d5c44917ca84ae91ebe91bf4fa2f1af0e7;p=working%2FEvergreen.git

Change hold targeter to not pull out the pickup lib.

There is an issue where if a hold only finds items at the local
pickup library that are potential hold copies, it would ignore
the closed at pickup lib. This should force that setting to be
checked no matter what.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Utils/HoldTargeter.pm b/Open-ILS/src/perlmods/lib/OpenILS/Utils/HoldTargeter.pm
index 44685cff7c..225e3cf286 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Utils/HoldTargeter.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Utils/HoldTargeter.pm
@@ -679,14 +679,10 @@ sub compile_weighted_proximity_map {
 sub filter_closed_date_copies {
     my $self = shift;
 
-    # Pre-fetch the org setting value for all represented circ libs that
-    # are closed, minuse the pickup_lib, since it has its own special setting.
+    # Pre-fetch the org setting value for all represented circ libs that are closed
     my $circ_libs = $self->get_copy_circ_libs;
     $circ_libs = [
-        grep {
-            $self->parent->{closed_orgs}->{$_} && 
-            $_ ne $self->hold->pickup_lib
-        } @$circ_libs
+        grep {$self->parent->{closed_orgs}->{$_}} @$circ_libs
     ];
 
     # If none of the represented circ libs are closed, we're done here.