From: Mike Rylander <mrylander@gmail.com>
Date: Mon, 3 Mar 2014 19:26:46 +0000 (-0500)
Subject: LP#1243023: Clean up string handling variable types
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=d3987e2030981ea8882a6d688f81e4eb7be3397b;p=evergreen%2Fpines.git

LP#1243023: Clean up string handling variable types

It was already TEXT, no need to flip back and forth between that
and XML.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
---

diff --git a/Open-ILS/src/sql/Pg/011.schema.authority.sql b/Open-ILS/src/sql/Pg/011.schema.authority.sql
index 7033773ee1..d3527f293f 100644
--- a/Open-ILS/src/sql/Pg/011.schema.authority.sql
+++ b/Open-ILS/src/sql/Pg/011.schema.authority.sql
@@ -350,10 +350,10 @@ BEGIN
         nfi_used := acsaf.nfi;
         joiner_text := COALESCE(acsaf.joiner, ' ');
 
-        FOR tmp_xml IN SELECT UNNEST(XPATH('//*[@tag="'||tag_used||'"]', marcxml::XML)) LOOP
+        FOR tmp_xml IN SELECT UNNEST(XPATH('//*[@tag="'||tag_used||'"]', marcxml::XML)::TEXT[]) LOOP
 
             heading_text := COALESCE(
-                oils_xpath_string('./*[contains("'||acsaf.display_sf_list||'",@code)]', tmp_xml::TEXT, joiner_text),
+                oils_xpath_string('./*[contains("'||acsaf.display_sf_list||'",@code)]', tmp_xml, joiner_text),
                 ''
             );