From: Mike Rylander <mrylander@gmail.com>
Date: Thu, 6 Nov 2014 21:03:36 +0000 (-0500)
Subject: LP#1390225: Fail to care about errors from auth.session.delete
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=d4b2ab2fe147be289bcdd5869dd664e013306818;p=evergreen%2Fpines.git

LP#1390225: Fail to care about errors from auth.session.delete

We're just tossing this call over the wall and moving on.  We don't
care if the session wasn't there to delete or even if we didn't pass
a session to the server.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader.pm
index 868907d22b..3d717adf3d 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader.pm
@@ -483,11 +483,13 @@ sub load_logout {
     # while logged in, go ahead and clear it out.
     $self->clear_anon_cache;
 
-    $U->simplereq(
-        'open-ils.auth',
-        'open-ils.auth.session.delete',
-        $self->cgi->cookie(COOKIE_SES)
-    );
+    try { # a missing auth token will cause an ugly explosion
+        $U->simplereq(
+            'open-ils.auth',
+            'open-ils.auth.session.delete',
+            $self->cgi->cookie(COOKIE_SES)
+        );
+    } catch Error with {};
 
     return $self->generic_redirect(
         $redirect_to || $self->ctx->{home_page},