From: Daniel Rizea <danielrizea27@gmail.com>
Date: Thu, 12 Apr 2012 19:10:53 +0000 (-0400)
Subject: Remove unused bypass hold library setting
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=d933e14655786b760dd187ae7b167cc5d7a3194c;p=evergreen%2Fmasslnc.git

Remove unused bypass hold library setting

Added sql upgrade script that removes bypass hold.. library setting

[This lacks Daniel's signoff, but I've tested this and it works, so I'll
let it pass this time just for the sake of getting one more bug closed.]

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
---

diff --git a/Open-ILS/src/sql/Pg/002.schema.config.sql b/Open-ILS/src/sql/Pg/002.schema.config.sql
index e1f8381576..41a66b7016 100644
--- a/Open-ILS/src/sql/Pg/002.schema.config.sql
+++ b/Open-ILS/src/sql/Pg/002.schema.config.sql
@@ -87,7 +87,7 @@ CREATE TRIGGER no_overlapping_deps
     BEFORE INSERT OR UPDATE ON config.db_patch_dependencies
     FOR EACH ROW EXECUTE PROCEDURE evergreen.array_overlap_check ('deprecates');
 
-INSERT INTO config.upgrade_log (version, applied_to) VALUES ('0738', :eg_version); -- senator/dbwells
+INSERT INTO config.upgrade_log (version, applied_to) VALUES ('0739', :eg_version); -- drizea/senator
 
 CREATE TABLE config.bib_source (
 	id		SERIAL	PRIMARY KEY,
diff --git a/Open-ILS/src/sql/Pg/950.data.seed-values.sql b/Open-ILS/src/sql/Pg/950.data.seed-values.sql
index e5daf85d12..7a6eb16880 100644
--- a/Open-ILS/src/sql/Pg/950.data.seed-values.sql
+++ b/Open-ILS/src/sql/Pg/950.data.seed-values.sql
@@ -2999,15 +2999,6 @@ INSERT into config.org_unit_setting_type
         'coust', 'description'),
     'link', 'ccs')
 
-,( 'circ.holds.clear_shelf.no_capture_holds', 'holds',
-    oils_i18n_gettext('circ.holds.clear_shelf.no_capture_holds',
-        'Bypass hold capture during clear shelf process',
-        'coust', 'label'),
-    oils_i18n_gettext('circ.holds.clear_shelf.no_capture_holds',
-        'During the clear shelf process, avoid capturing new holds on cleared items.',
-        'coust', 'description'),
-    'bool', null)
-
 ,( 'circ.holds.default_estimated_wait_interval', 'holds',
     oils_i18n_gettext('circ.holds.default_estimated_wait_interval',
         'Default Estimated Wait',
diff --git a/Open-ILS/src/sql/Pg/upgrade/0739.remove_bypass_hold_library_setting.sql b/Open-ILS/src/sql/Pg/upgrade/0739.remove_bypass_hold_library_setting.sql
new file mode 100644
index 0000000000..66d3917fd0
--- /dev/null
+++ b/Open-ILS/src/sql/Pg/upgrade/0739.remove_bypass_hold_library_setting.sql
@@ -0,0 +1,13 @@
+-- remove the Bypass hold capture during clear shelf process setting
+BEGIN;
+
+SELECT evergreen.upgrade_deps_block_check('0739', :eg_version);
+
+
+DELETE FROM actor.org_unit_setting WHERE name = 'circ.holds.clear_shelf.no_capture_holds';
+DELETE FROM config.org_unit_setting_type_log WHERE field_name = 'circ.holds.clear_shelf.no_capture_holds';
+
+
+DELETE FROM config.org_unit_setting_type WHERE name = 'circ.holds.clear_shelf.no_capture_holds';
+
+COMMIT;