From: Mike Rylander <mrylander@gmail.com>
Date: Fri, 14 Aug 2020 19:35:10 +0000 (-0400)
Subject: LP#1858114: Fix thinko in template-parameter collection
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=dc61ab61e94a613c573b125407d0d324fb8fc592;p=working%2FEvergreen.git

LP#1858114: Fix thinko in template-parameter collection

Minor thinko in the use of Array.prototype.concat() when gathering the
"where" and "having" template parameters -- concat() does not alter the
array it is called on, so we need to assign the result back to the
array.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
---

diff --git a/Open-ILS/web/reports/oils_rpt.js b/Open-ILS/web/reports/oils_rpt.js
index 3a755527b1..822217ad8a 100644
--- a/Open-ILS/web/reports/oils_rpt.js
+++ b/Open-ILS/web/reports/oils_rpt.js
@@ -154,7 +154,7 @@ oilsReport.prototype._gatherParams = function(params, arr, type, field) {
 
 oilsReport.prototype.gatherTemplateParams = function() {
     var arr = this.__gatherTemplateParams(this.def.where, 'where');
-    arr.concat(this.__gatherTemplateParams(this.def.having, 'having'));
+    arr = arr.concat(this.__gatherTemplateParams(this.def.having, 'having'));
     _debug("template params: " + js2JSON(arr));
     return arr;
 }