From: Jason Stephenson <jason@sigio.com>
Date: Mon, 8 Sep 2014 01:14:32 +0000 (-0400)
Subject: Fix a logic error in NCIP::ILS::Evergreen->acceptitem.
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=dc89dfd0d2b9d201d0495a11f18d413381f226ff;p=working%2FNCIPServer.git

Fix a logic error in NCIP::ILS::Evergreen->acceptitem.

This is embarrassing: I had =~, when I really wanted !~, when
checking the value of RequestedActionType.

Signed-off-by: Jason Stephenson <jason@sigio.com>
---

diff --git a/lib/NCIP/ILS/Evergreen.pm b/lib/NCIP/ILS/Evergreen.pm
index aebe23d..558890a 100644
--- a/lib/NCIP/ILS/Evergreen.pm
+++ b/lib/NCIP/ILS/Evergreen.pm
@@ -346,7 +346,7 @@ sub acceptitem {
     $response->header($self->make_header($request));
 
     # We only accept holds for the time being.
-    if ($request->{$message}->{RequestedActionType} =~ /^hold\w/i) {
+    if ($request->{$message}->{RequestedActionType} !~ /^hold\w/i) {
         # We need the item id or we can't do anything at all.
         my ($item_barcode, $item_idfield) = $self->find_item_barcode($request);
         if (ref($item_barcode) eq 'NCIP::Problem') {