From: Galen Charlton <gmc@equinoxinitiative.org>
Date: Thu, 15 Mar 2018 15:13:27 +0000 (-0400)
Subject: LP#1756110: fix egBasicComboBox drop-down functionality
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=dcb1bc27741ffeb7303a657af02a772a52c0cb2f;p=evergreen%2Fpines.git

LP#1756110: fix egBasicComboBox drop-down functionality

Somehow egBasicComboBox got missed when it became necessary to
switch to the newer way of specifying Bootstrap drop-downs. This
patch rectifies that and fixes the drop-down functionality.

To test
-------
[1] Create a report template in the web staff report editor and
    add a filter field.
[2] Attempt to change the filter operator. Note that nothing happens
    when the drop-down button is clicked.
[3] Apply the patch and repeat step 2. This time, the drop-down
    should work and display the list of available filter operators.

Other places affected include:

- The part selector in the volume/copy editor
- Template selector in the volume/copy editor
- Template selector in the labels interface
- Routing label selector in the subscription manager
- Call number prefix and suffix selectors in the serials batch receiving
  interface

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Conflicts:
	Open-ILS/web/js/ui/default/staff/services/ui.js
---

diff --git a/Open-ILS/web/js/ui/default/staff/services/ui.js b/Open-ILS/web/js/ui/default/staff/services/ui.js
index 24c6d50b12..cd9739041d 100644
--- a/Open-ILS/web/js/ui/default/staff/services/ui.js
+++ b/Open-ILS/web/js/ui/default/staff/services/ui.js
@@ -671,9 +671,9 @@ function($window , egStrings) {
         template:
             '<div class="input-group">'+
                 '<input placeholder="{{placeholder}}" type="text" ng-disabled="egDisabled" class="form-control" ng-model="selected" ng-change="makeOpen()" focus-me="focusMe">'+
-                '<div class="input-group-btn" dropdown ng-class="{open:isopen}">'+
-                    '<button type="button" ng-click="showAll()" ng-disabled="egDisabled" class="btn btn-default dropdown-toggle"><span class="caret"></span></button>'+
-                    '<ul class="dropdown-menu dropdown-menu-right">'+
+                '<div class="input-group-btn" uib-dropdown ng-class="{open:isopen}">'+
+                    '<button type="button" ng-click="showAll()" ng-disabled="egDisabled" class="btn btn-default" uib-dropdown-toggle><span class="caret"></span></button>'+
+                    '<ul uib-dropdown-menu class="dropdown-menu-right">'+
                         '<li ng-repeat="item in list|filter:selected:compare"><a href ng-click="changeValue(item)">{{item}}</a></li>'+
                         '<li ng-if="complete_list" class="divider"><span></span></li>'+
                         '<li ng-if="complete_list" ng-repeat="item in list"><a href ng-click="changeValue(item)">{{item}}</a></li>'+