From: Jason Etheridge <jason@EquinoxOLI.org>
Date: Thu, 26 May 2022 18:45:51 +0000 (-0400)
Subject: tweaks to SIP2 Checkout Response
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=de9638169129893e262b9e514a05f8e3f175a49e;p=working%2FEvergreen.git

tweaks to SIP2 Checkout Response

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm
index 680dd51cf1..5174ed3090 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm
@@ -529,12 +529,15 @@ sub checkout_renew_common {
         ],
         fields => [
             {AA => $patron_barcode},
-            {AB => $item_barcode}
+            {AB => $item_barcode},
+            {AO => $config->{institution}},
+            {AH => ''}
         ]
     };
 
     my $item_details = OpenILS::Application::SIP2::Item->get_item_details(
         $session, barcode => $item_barcode);
+    push @{ $stub->{fields} }, {AJ => $item_details->{title}};
 
     return $stub unless $item_details;
 
@@ -567,7 +570,9 @@ sub checkout_renew_common {
         code => $code,
         fixed_fields => [
             $circ ? 1 : 0,              # checkout ok
-            $SC->sipbool($can_renew),   # renewal ok
+            # Per SIP spec, "renewal ok" is a bit dumber than $can_renew, and returns Y if the item was already circulating to the patron, N otherwise)
+            # FIXME: Hardcoded for now, but need to revisit
+            $SC->sipbool(0),            # renewal ok
             $SC->sipbool($magnetic),    # magnetic media
             $SC->sipbool(!$magnetic),   # desensitize
             $SC->sipdate,               # transaction date
@@ -578,7 +583,7 @@ sub checkout_renew_common {
             {AJ => $item_details->{title}},
             {AO => $config->{institution}},
             {BT => $item_details->{fee_type}},
-            {CI => 0}, # security inhibit
+            {CI => 'N'}, # security inhibit
             {CK => $item_details->{media_type}},
             $screen_msg ? {AF => $screen_msg}   : (),
             $due_date   ? {AH => $due_date}     : (),