From: Jason Etheridge <phasefx@gmail.com>
Date: Fri, 12 May 2023 15:25:09 +0000 (-0400)
Subject: delint
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=e1983e545e30af024437b46f96a68b99a6830fa2;p=working%2FEvergreen.git

delint

Signed-off-by: Jason Etheridge <phasefx@gmail.com>
---

diff --git a/Open-ILS/src/eg2/src/app/share/grid/grid-manage-filters-dialog.component.ts b/Open-ILS/src/eg2/src/app/share/grid/grid-manage-filters-dialog.component.ts
index a0a22a0a5f..cc047f6b03 100644
--- a/Open-ILS/src/eg2/src/app/share/grid/grid-manage-filters-dialog.component.ts
+++ b/Open-ILS/src/eg2/src/app/share/grid/grid-manage-filters-dialog.component.ts
@@ -1,29 +1,20 @@
-import {AlertDialogComponent} from '@eg/share/dialog/alert.component';
-import {AuthService} from '@eg/core/auth.service';
 import {ComboboxEntry, ComboboxComponent} from '@eg/share/combobox/combobox.component';
-import {Component, Input, OnInit, ViewChild, Renderer2} from '@angular/core';
+import {Component, Input, OnInit, OnDestroy, ViewChild, Renderer2} from '@angular/core';
 import {GridContext} from '@eg/share/grid/grid';
 import {DialogComponent} from '@eg/share/dialog/dialog.component';
-import {EventService} from '@eg/core/event.service';
-import {FormControl} from '@angular/forms';
-import {IdlService, IdlObject} from '@eg/core/idl.service';
-import {NetService} from '@eg/core/net.service';
 import {NgForm} from '@angular/forms';
 import {NgbModal} from '@ng-bootstrap/ng-bootstrap';
 import {PcrudService} from '@eg/core/pcrud.service';
-import {ProgressDialogComponent} from '@eg/share/dialog/progress.component';
 import {ServerStoreService} from '@eg/core/server-store.service';
-import {StringComponent} from '@eg/share/string/string.component';
-import {Subject, Subscription, Observable, from, EMPTY, throwError} from 'rxjs';
-import {ToastService} from '@eg/share/toast/toast.service';
-import {debounceTime, distinctUntilChanged, switchMap, takeLast, finalize} from 'rxjs/operators';
+import {Subject, Subscription} from 'rxjs';
+import {debounceTime, distinctUntilChanged} from 'rxjs/operators';
 
 @Component({
   selector: 'eg-grid-manage-filters-dialog',
   templateUrl: './grid-manage-filters-dialog.component.html'
 })
 
-export class GridManageFiltersDialogComponent extends DialogComponent implements OnInit {
+export class GridManageFiltersDialogComponent extends DialogComponent implements OnInit, OnDestroy {
 
     @Input() gridContext: GridContext;
 
@@ -40,16 +31,12 @@ export class GridManageFiltersDialogComponent extends DialogComponent implements
 
     constructor(
         private modal: NgbModal,
-        private auth: AuthService,
-        private evt: EventService,
-        private net: NetService,
-        private toast: ToastService,
-        private idl: IdlService,
         private pcrud: PcrudService,
         private renderer: Renderer2,
         private store: ServerStoreService,
     ) {
         super(modal);
+        if (this.modal) {} // noop for delinting
     }
 
     ngOnInit() {
@@ -135,6 +122,7 @@ export class GridManageFiltersDialogComponent extends DialogComponent implements
         let filterIncludeOrgAncestors = false;
         let filterIncludeOrgDescendants = false;
         let notSupported = false;
+        if (field_datatype) {} // delint TODO: remove this?
         switch(legacy_operator) {
             case '=': case '!=': case '>': case '<': case '>=': case '<=':
                 /* same */
@@ -200,13 +188,13 @@ export class GridManageFiltersDialogComponent extends DialogComponent implements
     // need to map those.  We also not able to support between, not between, in, and not in.
         this.pcrud.search('cfdfs', {'interface':this.gridContext.migrateLegacyFilterSets},{},{'atomic':true}).subscribe(
             (legacySets) => {
-                legacySets.forEach( s => {
+                legacySets.forEach( (s:any) => {
                     let obj = {
                         'filters' : {},
                         'controls' : {}
                     };
                     console.log('migrating legacy set ' + s.name(), s );
-                    JSON.parse( s.filters() ).forEach( f => {
+                    JSON.parse( s.filters() ).forEach( (f:any) => {
                         let mappedFieldName = this.legacyFieldMap(f.field);
                         let c = this.gridContext.columnSet.getColByName( mappedFieldName );
                         if (c) {