From: Dan Scott <dscott@laurentian.ca>
Date: Thu, 30 Aug 2012 04:21:01 +0000 (-0400)
Subject: Remove C compiler warning for writeAuditInfo
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=e5fe5acb22a7fe3d7e88ec0a8cf5a202410ef056;p=evergreen%2Fpines.git

Remove C compiler warning for writeAuditInfo

The C compiler was throwing the following warning:

oils_sql.c: In function 'writeAuditInfo':
oils_sql.c:7244:1: warning: control reaches end of non-void function
[-Wreturn-type]

By shifting the "return 0" to the end of the function, outside of the if
statements, we can ensure that we always return an int value.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
---

diff --git a/Open-ILS/src/c-apps/oils_sql.c b/Open-ILS/src/c-apps/oils_sql.c
index 5c93b296f6..b262a70953 100644
--- a/Open-ILS/src/c-apps/oils_sql.c
+++ b/Open-ILS/src/c-apps/oils_sql.c
@@ -7238,9 +7238,9 @@ int writeAuditInfo( osrfMethodContext* ctx, const char* user_id, const char* ws_
 			return -1;
 		} else {
 			dbi_result_free( result );
-			return 0;
 		}
 	}
+	return 0;
 }
 
 /*@}*/