From: Galen Charlton <gmc@equinoxinitiative.org>
Date: Thu, 31 Aug 2017 16:17:12 +0000 (-0400)
Subject: LP#1673870: some tidying up of JavaScript
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=e6b541bea9302ec004e28c88cda005efa0380527;p=working%2FEvergreen.git

LP#1673870: some tidying up of JavaScript

- test for ebook_spinner div before attempting to set a class
- eject a couple Perlisms

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
---

diff --git a/Open-ILS/web/js/ui/default/opac/ebook_api/loggedin.js b/Open-ILS/web/js/ui/default/opac/ebook_api/loggedin.js
index 335cecfc10..970066a91f 100644
--- a/Open-ILS/web/js/ui/default/opac/ebook_api/loggedin.js
+++ b/Open-ILS/web/js/ui/default/opac/ebook_api/loggedin.js
@@ -67,7 +67,7 @@ function addTransactionsToPage() {
     if (active_ebook && typeof active_ebook.vendor !== 'undefined') {
         active_ebook.ses = active_ebook.ses || dojo.cookie(active_ebook.vendor);
     }
-    dojo.addClass('ebook_spinner', "hidden");
+    if (dojo.byId('ebook_spinner')) dojo.addClass('ebook_spinner', "hidden");
     if (myopac_page) {
         console.log('updating page with cached transaction details, if applicable');
         if (myopac_page === 'ebook_circs')
@@ -173,7 +173,7 @@ function updateHoldView() {
                 var ebook = new Ebook(this.vendor, this.title_id);
                 ebook.cancelHold(authtoken, patron_id, function(resp) {
                     if (resp.error_msg) {
-                        console.log('Cancel hold failed: ' . resp.error_msg);
+                        console.log('Cancel hold failed: ' + resp.error_msg);
                         dojo.removeClass('ebook_cancel_hold_failed', "hidden");
                     } else {
                         console.log('Cancel hold succeeded!');
@@ -339,7 +339,7 @@ function doCheckout() {
 function doPlaceHold() {
     active_ebook.placeHold(authtoken, patron_id, function(resp) {
         if (resp.error_msg) {
-            console.log('Place hold failed: ' . resp.error_msg);
+            console.log('Place hold failed: ' + resp.error_msg);
             dojo.removeClass('ebook_place_hold_failed', "hidden");
         } else {
             console.log('Place hold succeeded!');