From: Dan Scott <dscott@laurentian.ca>
Date: Sun, 16 Jun 2013 13:19:09 +0000 (-0400)
Subject: Prevent undefined var warning for username
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=eb7d8827accdcaa94ede7e6b985705361db0f2c6;p=contrib%2FConifer.git

Prevent undefined var warning for username

EGCatLoader could generate undefined var warnings if submitted without a
username. Probably should just bail early rather than trying to log the
user in.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader.pm
index 992852b0e9..98fd69edb4 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader.pm
@@ -357,7 +357,7 @@ sub load_login {
 
     $ctx->{page} = 'login';
 
-    my $username = $cgi->param('username');
+    my $username = $cgi->param('username') || '';
     $username =~ s/\s//g;  # Remove blanks
     my $password = $cgi->param('password');
     my $org_unit = $ctx->{physical_loc} || $ctx->{aou_tree}->()->id;