From: Mike Risher <mrisher@catalyte.io>
Date: Mon, 10 Jun 2019 18:11:38 +0000 (-0700)
Subject: lp1770217 Items Out count shouldn't increment on renew
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=ebc26391df856719b645da9bd4323deea09ddced;p=evergreen%2Fpines.git

lp1770217 Items Out count shouldn't increment on renew

Determine if this item is currently out to the patron and is being
checked out again.  If so, be sure not to increment "Items Out" count.

Signed-off-by: Mike Risher <mrisher@catalyte.io>

Changes to be committed:
	modified:   web/js/ui/default/staff/circ/patron/checkout.js
	modified:   web/js/ui/default/staff/circ/services/circ.js

Signed-off-by: Bill Erickson <berickxx@gmail.com>
---

diff --git a/Open-ILS/web/js/ui/default/staff/circ/patron/checkout.js b/Open-ILS/web/js/ui/default/staff/circ/patron/checkout.js
index ba7c5453bb..f3df2d8ace 100644
--- a/Open-ILS/web/js/ui/default/staff/circ/patron/checkout.js
+++ b/Open-ILS/web/js/ui/default/staff/circ/patron/checkout.js
@@ -201,7 +201,7 @@ function($scope , $q , $routeParams , egCore , egUser , patronSvc ,
 
                 // Avoid updating checkout counts when a checkout turns
                 // into a renewal via auto_renew.
-                if (!co_resp.auto_renew && !params.noncat) {
+                if (!co_resp.auto_renew && !params.noncat && !options.sameCopyCheckout) {
                     patronSvc.patron_stats.checkouts.out++;
                     patronSvc.patron_stats.checkouts.total_out++;
                 }
diff --git a/Open-ILS/web/js/ui/default/staff/circ/services/circ.js b/Open-ILS/web/js/ui/default/staff/circ/services/circ.js
index 3e5c57d441..6c2d30d50e 100644
--- a/Open-ILS/web/js/ui/default/staff/circ/services/circ.js
+++ b/Open-ILS/web/js/ui/default/staff/circ/services/circ.js
@@ -1106,6 +1106,7 @@ function($uibModal , $q , egCore , egAlertDialog , egConfirmDialog,  egAddCopyAl
             function(args) {
                 if (sameUser) {
                     params.void_overdues = args.forgive_fines;
+                    options.sameCopyCheckout = true;
                     return service.renew(params, options);
                 }