From: senator <lebbeous@esilibrary.com>
Date: Thu, 3 Feb 2011 18:37:22 +0000 (-0500)
Subject: addressed existing onchange handlers
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=ebf294156790272a0eafac92ac7086dec8f9634e;p=evergreen%2Fequinox.git

addressed existing onchange handlers
---

diff --git a/Open-ILS/web/opac/skin/kcls-wire/js/misc.js b/Open-ILS/web/opac/skin/kcls-wire/js/misc.js
index 0f3bf81ed1..3e53964ff9 100644
--- a/Open-ILS/web/opac/skin/kcls-wire/js/misc.js
+++ b/Open-ILS/web/opac/skin/kcls-wire/js/misc.js
@@ -76,3 +76,22 @@ function swapTabs(el) {
         }
     }
 }
+
+function sortHolds() {
+    alert("FIXME disconnected");
+    /* XXX TODO There was a method for sorting loaded holds in the DOM
+     * without reloading the page, but it was reliant on fieldmapper
+     * and some stock dojo libraries.  Could be reimplemented without
+     * deps if deemed worth it.
+     */
+}
+
+function showDetailedResults(/* Boolean */ detailed) {
+    alert("FIXME disconnected");
+    /* XXX TODO this stands in for an old onchange handler that toggled
+     * between simple and detailed results in the rresults page.
+     * Don't know if we want to keep this around or not (I'm guessing not,
+     * and that we'll do this with two different server-side pages now,
+     * but leaving this stub here for now).
+     */
+}
diff --git a/Open-ILS/web/templates/default/kcls-wire/parts/advanced/search.tt2 b/Open-ILS/web/templates/default/kcls-wire/parts/advanced/search.tt2
index 2083e8ec15..3808123935 100644
--- a/Open-ILS/web/templates/default/kcls-wire/parts/advanced/search.tt2
+++ b/Open-ILS/web/templates/default/kcls-wire/parts/advanced/search.tt2
@@ -187,11 +187,16 @@
                             <span>&advanced.filter.pubyear;</span>
                         </td>
                         <td align='left'>
-                            <select id='adv_global_pub_date_type' onchange='
+                            <!-- XXX TODO the following select used to have this
+                                onchange handler:
                                 if($("adv_global_pub_date_type").selectedIndex == 3)
                                     unHideMe($("adv_global_pub_date_2_span"));
                                 else
-                                    hideMe($("adv_global_pub_date_2_span"));'>
+                                    hideMe($("adv_global_pub_date_2_span"));
+
+                                So do we need equiv functionality or no?
+                                -->
+                            <select id='adv_global_pub_date_type'>
                                     <option value='equals' selected='selected'>
                                         &advanced.filter.pubyear.equals;
                                     </option>
diff --git a/Open-ILS/web/templates/default/kcls-wire/results.tt2 b/Open-ILS/web/templates/default/kcls-wire/results.tt2
index 8d8c28678a..2e2811b7f9 100644
--- a/Open-ILS/web/templates/default/kcls-wire/results.tt2
+++ b/Open-ILS/web/templates/default/kcls-wire/results.tt2
@@ -36,7 +36,7 @@
                 <div class="results_header_div"></div>
                 <div class="results_header_lbl">View</div>
                 <select class="results_header_sel" style="width:88px;"
-                    onchange="this.selectedIndex?showDetailedInfo(true):showDetailedInfo(false);">
+                    onchange="showDetailedResults(Boolean(this.selectedIndex));">
                     <option>Simple</option>
                     <option>Detailed</option>
                 </select>