From: Galen Charlton <gmc@equinoxOLI.org>
Date: Fri, 20 May 2022 14:27:04 +0000 (-0400)
Subject: LP#1857910: (follow-up) enhance IDL for field doc
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=eddc58f4a29afc285931bd87ea3395a2e8a04d0a;p=contrib%2FConifer.git

LP#1857910: (follow-up) enhance IDL for field doc

This patch adds human-readable labels to the IDL for
field doc. It also marks required fields in the IDL, removing
the need for the Angular code to explicitly specify
the set of required fields.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
---

diff --git a/Open-ILS/examples/fm_IDL.xml b/Open-ILS/examples/fm_IDL.xml
index 92abe1547d..d036e9ddd4 100644
--- a/Open-ILS/examples/fm_IDL.xml
+++ b/Open-ILS/examples/fm_IDL.xml
@@ -9084,11 +9084,11 @@ SELECT  usr,
 	</class>
 	<class id="fdoc" controller="open-ils.cstore open-ils.pcrud" oils_obj:fieldmapper="config::idl_field_doc" oils_persist:tablename="config.idl_field_doc" oils_persist:field_safe="true" reporter:label="IDL Field Doc">
 		<fields oils_persist:primary="id" oils_persist:sequence="config.idl_field_doc_id_seq">
-			<field name="id" reporter:datatype="id" />
-			<field name="fm_class" reporter:datatype="text"/>
-			<field name="field" reporter:datatype="text"/>
-			<field name="owner" reporter:datatype="org_unit"/>
-			<field name="string" reporter:datatype="text" oils_persist:i18n="true"/>
+			<field name="id"       reporter:label="ID" reporter:datatype="id" />
+			<field name="fm_class" reporter:label="Class" reporter:datatype="text" oils_obj:required="true"/>
+			<field name="field"    reporter:label="Field" reporter:datatype="text" oils_obj:required="true"/>
+			<field name="owner"    reporter:label="Field Documentation Owner" reporter:datatype="org_unit" oils_obj:required="true"/>
+			<field name="string"   reporter:label="Field Documentation" reporter:datatype="text" oils_persist:i18n="true" oils_obj:required="true"/>
 		</fields>
 		<links>
 			<link field="owner" reltype="has_a" key="id" map="" class="aou"/>
diff --git a/Open-ILS/src/eg2/src/app/staff/admin/local/field-documentation/field-documentation.component.html b/Open-ILS/src/eg2/src/app/staff/admin/local/field-documentation/field-documentation.component.html
index 2227625ffc..ebaafff5bd 100644
--- a/Open-ILS/src/eg2/src/app/staff/admin/local/field-documentation/field-documentation.component.html
+++ b/Open-ILS/src/eg2/src/app/staff/admin/local/field-documentation/field-documentation.component.html
@@ -35,7 +35,7 @@
 </div>
 
 <eg-fm-record-editor #editDialog hiddenFields="id" idlClass="fdoc"
-  requiredFields="fm_class,field,owner,string" [(fieldOptions)]="fieldOptions">
+  [(fieldOptions)]="fieldOptions">
 </eg-fm-record-editor>
 
 <ng-template #fieldClassSelector let-fieldentries="fieldentries" let-selected="selectedEntry">