From: Kathy Lussier <klussier@masslnc.org>
Date: Tue, 20 Jun 2017 20:31:43 +0000 (-0400)
Subject: LP#1693560: Remove permission check for retrieve tag table function
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=eeaaa73d7b896c38d63aa111a1fdd708c1831a62;p=evergreen%2Ftadl.git

LP#1693560: Remove permission check for retrieve tag table function

The permission check for the retrieve tag table function was preventing
users who don't have the UPDATE_MARC permssion from performing searches
in the staff catalog. Since there's nothing confidential in the table,
this commit removes that permission check. Thanks to Jason Boyer for
finding the source of the problem.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Cat.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Cat.pm
index f48ff7a571..211e7c88c5 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Cat.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Cat.pm
@@ -1654,7 +1654,6 @@ sub retrieve_tag_table {
     my( $self, $conn, $auth, $marc_format, $marc_record_type ) = @_;
     my $e = new_editor( authtoken=>$auth, xact=>1 );
     return $e->die_event unless $e->checkauth;
-    return $e->die_event unless $e->allowed('UPDATE_MARC', $e->requestor->ws_ou);
 
     my $field_list_only = ($self->api_name =~ /\.field_list\./) ? 1 : 0;
     my $context_ou;