From: Galen Charlton <gmc@esilibrary.com>
Date: Mon, 31 Oct 2011 15:46:48 +0000 (-0400)
Subject: lp849447: trival stylistic tweaks
X-Git-Tag: sprint4-merge-nov22~4838
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=ef82b6171473d9f4c705e5bd1db592d72746ae2d;p=working%2FEvergreen.git

lp849447: trival stylistic tweaks

- rename variable avoid double-negative
- avoid 'Variable declared in conditional statement' perlcritic gripe

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
index 4c1323c627..d2b2085af6 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
@@ -287,13 +287,13 @@ sub charge_ok {
     # determine whether patron should be allowed to circulate materials:
     # not barred, doesn't owe too much wrt fines/fees, privileges haven't
     # expired
-    my $no_circ = 't' if
+    my $circ_is_blocked = 
         (($u->barred eq 't') or
          ($u->standing_penalties and @{$u->standing_penalties}) or
          (CORE::time > $expire->epoch));
 
     return
-        !$no_circ and
+        !$circ_is_blocked and
         $u->active eq 't' and
         $u->card->active eq 't';
 }