From: Cesar Velez <cesar.velez@equinoxinitiative.org>
Date: Tue, 23 May 2017 13:58:39 +0000 (-0400)
Subject: LP#1669534 - OPAC hold request should not default to first SMS carrier
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=f07a4bc39bd9d8d5f7bb644a947237a4dd72ad2e;p=working%2FEvergreen.git

LP#1669534 - OPAC hold request should not default to first SMS carrier

Added empty <option> tag to address this and related form validation issues.

To test
-------
[0] Ensure that SMS messaging is enabled.
[1] Apply the patch and go to the place hold form in the public
    catalog. Verify that no mobile carrier is selected.
[2] Set the default SMS carrier and number for the user account
    and go back to the place hold form. Verify that the user's
    default carrier and number appear in the form.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
---

diff --git a/Open-ILS/src/templates/opac/parts/sms_carrier_selector.tt2 b/Open-ILS/src/templates/opac/parts/sms_carrier_selector.tt2
index 919ba074d1..1f66d15541 100644
--- a/Open-ILS/src/templates/opac/parts/sms_carrier_selector.tt2
+++ b/Open-ILS/src/templates/opac/parts/sms_carrier_selector.tt2
@@ -19,6 +19,7 @@
 %]
 [% IF NOT sms_carrier_hide_label; l('Mobile carrier:'); END; %]
 <select name="sms_carrier">
+    <option value="">[% l('') %]</option>
     [% FOR carrier IN carriers.sort('name','region') -%]
     <option value='[% carrier.id | html %]'[%
         default_carrier == carrier.id ? ' selected="selected"' : ''