From: Galen Charlton <gmc@esilibrary.com>
Date: Mon, 14 Oct 2013 16:21:58 +0000 (-0700)
Subject: LP#1086458: remove unecessary anonymous hashes when calling xulG.set_tab()
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=f0e75d70147afc087af0d63a3f70163a409971c5;p=Evergreen.git

LP#1086458: remove unecessary anonymous hashes when calling xulG.set_tab()

This follows up on observations made by Steven Chan that
suggests that even the act of creating an anonymous hash and
passing it to a global function can cause (I assume) JavaScript
execution contexts to be leaked.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
---

diff --git a/Open-ILS/xul/staff_client/chrome/content/main/menu.js b/Open-ILS/xul/staff_client/chrome/content/main/menu.js
index b7a95438e5..414baec673 100644
--- a/Open-ILS/xul/staff_client/chrome/content/main/menu.js
+++ b/Open-ILS/xul/staff_client/chrome/content/main/menu.js
@@ -1766,7 +1766,7 @@ main.menu.prototype = {
             'refresh_checkout',
             function() {
                 try {
-                    obj.set_tab(obj.url_prefix('XUL_PATRON_BARCODE_ENTRY'),{},{});
+                    obj.set_tab(obj.url_prefix('XUL_PATRON_BARCODE_ENTRY'));
                 } catch(E) {
                     obj.error.sdump('D_ERROR','tab_refresh_checkout_handler: ' + js2JSON(E));
                 }