From: Thomas Berezansky <tsbere@mvlc.org>
Date: Mon, 30 Jan 2012 15:09:17 +0000 (-0500)
Subject: Fix "Clear Shelf Expired Holds" checkin modifier
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=f2a40ab35ce77f41eda6a7101026dadd5e8e4380;p=contrib%2FConifer.git

Fix "Clear Shelf Expired Holds" checkin modifier

By not looking up empty arrays there either.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
index fe1b93075c..17ae306f26 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
@@ -3445,7 +3445,8 @@ sub clear_shelf_process {
         # refetch the holds to pick up the caclulated cancel_time, 
         # which may be needed by Action/Trigger
         $e->xact_begin;
-        my $updated_holds = $e->search_action_hold_request({id => \@canceled_holds}, {substream => 1});
+        my $updated_holds = [];
+        $updated_holds = $e->search_action_hold_request({id => \@canceled_holds}, {substream => 1}) if (@canceled_holds > 0);
         $e->rollback;
 
         $U->create_events_for_hook(