From: Chris Cormack <chrisc@catalyst.net.nz>
Date: Thu, 2 Jan 2014 20:44:35 +0000 (+1300)
Subject: Tidying up the LookUpUser handler
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=f5ef7b81db73585664077270678e0d192c494c19;p=NCIPServer.git

Tidying up the LookUpUser handler
---

diff --git a/lib/NCIP/Handler/LookupUser.pm b/lib/NCIP/Handler/LookupUser.pm
index 2cc984f..d766122 100644
--- a/lib/NCIP/Handler/LookupUser.pm
+++ b/lib/NCIP/Handler/LookupUser.pm
@@ -25,18 +25,25 @@ sub handle {
     my $xmldoc = shift;
     if ($xmldoc) {
 
-        # Given our xml document, lets find the itemid
+        # Given our xml document, lets find our userid
         my ($user_id) =
           $xmldoc->getElementsByTagNameNS( $self->namespace(),
             'UserIdentifierValue' );
 
+        # We may get a password, username combo instead of userid
+        # Need to deal with that also
+
         my $user = NCIP::User->new(
             { userid => $user_id->textContent(), ils => $self->ils } );
         $user->initialise();
+        my $root = $xmldoc->documentElement();
+        my @elements = $root->findnodes('LookupUser/UserElementType/Value');
+        #set up the variables for our template
         my $vars;
         $vars->{'messagetype'} = 'LookupUserResponse';
-        $vars->{'user'} = $user;
-        my $output = $self->render_output('response.tt',$vars);
+        $vars->{'elements'}    = \@elements;
+        $vars->{'user'}        = $user;
+        my $output = $self->render_output( 'response.tt', $vars );
         return $output;
 
     }
diff --git a/templates/includes/LookupUserResponse.inc b/templates/includes/LookupUserResponse.inc
index 8af9c7f..ec03c40 100644
--- a/templates/includes/LookupUserResponse.inc
+++ b/templates/includes/LookupUserResponse.inc
@@ -1 +1,3 @@
-Look up user
+[% FOREACH element IN elements %]
+  [% element.textContent %]
+[% END %]