From: Galen Charlton <gmc@equinoxinitiative.org>
Date: Tue, 27 Feb 2018 22:23:22 +0000 (-0500)
Subject: LP#1676608: don't sound the klaxon for unusual copy statuses during checkin
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=f736176ddae994baefa62c8427f3f441f585e39e;p=evergreen%2Fjoelewis.git

LP#1676608: don't sound the klaxon for unusual copy statuses during checkin

During a successful checkin, play the success sound if an
unexpected copy status is noted in the success message -- it
may have been set via a copy alert.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
---

diff --git a/Open-ILS/web/js/ui/default/staff/circ/services/circ.js b/Open-ILS/web/js/ui/default/staff/circ/services/circ.js
index f349f6c2ac..f19188488e 100644
--- a/Open-ILS/web/js/ui/default/staff/circ/services/circ.js
+++ b/Open-ILS/web/js/ui/default/staff/circ/services/circ.js
@@ -1493,8 +1493,8 @@ function($uibModal , $q , egCore , egAlertDialog , egConfirmDialog,  egAddCopyAl
                         return $q.when(final_resp);
 
                     default:
-                        egCore.audio.play('error.checkin.unknown');
-                        console.error('Unhandled checkin copy status: ' 
+                        egCore.audio.play('success.checkin');
+                        console.debug('Unusual checkin copy status (may have been set via copy alert): '
                             + copy.status().id() + ' : ' + copy.status().name());
                         return $q.when(final_resp);
                 }