From: Lebbeous Fogle-Weekley Date: Fri, 19 Apr 2013 19:23:05 +0000 (-0400) Subject: Repair too-timid hold targeter (it misses copies at other org units) X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=fa8bdbecb4ebb7662e17aa020ee46907ea76cb04;p=Evergreen.git Repair too-timid hold targeter (it misses copies at other org units) The patch to address bug 1162989 overreached. Whereas before that patch, the hold targeter was wont to target copies with unholdable statuses, after the patch the hold targeter got the statuses right but undesirably filtered out copies whose circ_lib doesn't match the hold pickup lib. This again probably stems from the differences between FulfILLment's hold targeter and Evergreen's in the context of merging the calculated proximity code. This patch should resolve the issue. Signed-off-by: Lebbeous Fogle-Weekley Signed-off-by: Kathy Lussier Signed-off-by: Mike Rylander --- diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm index f18a254623..ed5c4adb37 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm @@ -1615,7 +1615,7 @@ sub new_hold_copy_targeter { # reset prox list after trimming good copies $prox_list = create_prox_list( $self, $pu_lib, - [ grep { ''.$_->circ_lib eq $pu_lib && ( $_->status == 0 || $_->status == 7 ) } @good_copies ], + [ grep { $_->status == 0 || $_->status == 7 } @good_copies ], $hold );