From: Jeff Godin <jgodin@tadl.org>
Date: Thu, 22 May 2014 20:36:48 +0000 (-0400)
Subject: Fix container_date sort with non-unique contents
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=fba100e01e053945a02b719d50ad7d49453f34d7;p=working%2FEvergreen.git

Fix container_date sort with non-unique contents

It is possible for a bre container to have multiple items pointing
to the same bib. In these cases, a container_date sort attempt would
fail with:

ERROR:  more than one row returned by a subquery used as an
expression

This fix considers only a single date, the most recent time a given
bib was added to the container.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm
index 788dc2952a..07cae513e8 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm
@@ -822,7 +822,7 @@ sub toSQL {
     } elseif ($sort_filter eq 'container_date' && @{$$flat_plan{container_list}}) {
         # Just the first container for now
         my $container_id = $self->QueryParser->quote_value(@{$$flat_plan{container_list}}[0]);
-        $rank = "FIRST((SELECT create_time FROM container.biblio_record_entry_bucket_item cbrebi WHERE cbrebi.target_biblio_record_entry = m.source AND cbrebi.bucket = " . $container_id . "))";
+        $rank = "FIRST((SELECT create_time FROM container.biblio_record_entry_bucket_item cbrebi WHERE cbrebi.target_biblio_record_entry = m.source AND cbrebi.bucket = " . $container_id . " ORDER BY create_time DESC LIMIT 1))";
     } else {
         # default to rel ranking
         $rank = $rel;