From: Jason Stephenson <jason@sigio.com>
Date: Sat, 22 Apr 2017 00:42:49 +0000 (-0400)
Subject: LP#1684984: Remove obsolete ingest.disable_metabib_field_entry flag.
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=fd0b8378b187432d33b7f00a3530bb9987a21583;p=working%2FEvergreen.git

LP#1684984: Remove obsolete ingest.disable_metabib_field_entry flag.

Per discussion in IRC, the ingest.disable_metabib_field_entry internal
flag was obsoleted by the addition of the ingest.skip_browse_indexing,
ingest.skip_search_indexing, and ingest.skip_facet_indexing
flags. Since ingest.disable_metabib_field_entry is not used anywhere
in the database, this branch removes it.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
---

diff --git a/Open-ILS/src/sql/Pg/002.schema.config.sql b/Open-ILS/src/sql/Pg/002.schema.config.sql
index bfeeb14776..0889fde31c 100644
--- a/Open-ILS/src/sql/Pg/002.schema.config.sql
+++ b/Open-ILS/src/sql/Pg/002.schema.config.sql
@@ -44,7 +44,6 @@ INSERT INTO config.internal_flag (name) VALUES ('ingest.reingest.force_on_same_m
 INSERT INTO config.internal_flag (name) VALUES ('ingest.disable_located_uri');
 INSERT INTO config.internal_flag (name) VALUES ('ingest.disable_metabib_full_rec');
 INSERT INTO config.internal_flag (name) VALUES ('ingest.disable_metabib_rec_descriptor');
-INSERT INTO config.internal_flag (name) VALUES ('ingest.disable_metabib_field_entry');
 INSERT INTO config.internal_flag (name) VALUES ('ingest.assume_inserts_only');
 INSERT INTO config.internal_flag (name) VALUES ('ingest.skip_browse_indexing');
 INSERT INTO config.internal_flag (name) VALUES ('ingest.skip_search_indexing');
diff --git a/Open-ILS/src/sql/Pg/t/lp1684984-remove-ingest.disable_metabib_field_entry.pg b/Open-ILS/src/sql/Pg/t/lp1684984-remove-ingest.disable_metabib_field_entry.pg
new file mode 100644
index 0000000000..45bb22239a
--- /dev/null
+++ b/Open-ILS/src/sql/Pg/t/lp1684984-remove-ingest.disable_metabib_field_entry.pg
@@ -0,0 +1,13 @@
+BEGIN;
+
+SELECT plan(1);
+
+-- Check that config.internal_flag ingest.disable_metabib_field_entry does not exist.
+SELECT is_empty(
+    'SELECT * FROM config.internal_flag WHERE name = $$ingest.disable_metabib_field_entry$$',
+    'config.internal_flag ingest.disable_metabib_field_entry does not exist'
+);
+
+SELECT * FROM finish();
+
+ROLLBACK;
diff --git a/Open-ILS/src/sql/Pg/upgrade/XXXX.data.remove_ingest.disable_metabib_field_entry.sql b/Open-ILS/src/sql/Pg/upgrade/XXXX.data.remove_ingest.disable_metabib_field_entry.sql
new file mode 100644
index 0000000000..091c618a9b
--- /dev/null
+++ b/Open-ILS/src/sql/Pg/upgrade/XXXX.data.remove_ingest.disable_metabib_field_entry.sql
@@ -0,0 +1,13 @@
+BEGIN;
+
+-- SELECT evergreen.upgrade_deps_block_check('XXXX', :eg_version);
+
+-- Per Lp bug 1684984, the config.internal_flag,
+-- ingest.disable_metabib_field_entry, was made obsolete by the
+-- addition of the ingest.skip_browse_indexing,
+-- ingest.skip_search_indexing, and ingest.skip_facet_indexing flags.
+-- Since it is not used in the database, we delete it.
+DELETE FROM config.internal_flag
+WHERE name = 'ingest.disable_metabib_field_entry';
+
+COMMIT;