From: Dan Scott <dan@coffeecode.net>
Date: Mon, 18 Feb 2013 22:59:45 +0000 (-0500)
Subject: Fix failing SIP unit test
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=fd5785cb9c65e10e775bd10088c0dbc29afd977f;p=evergreen%2Fpines.git

Fix failing SIP unit test

Per LP# 1099595, just copy the constant inline instead of requiring the
SIPServer code to be installed on every instance where you don't want
'make check' to fail. (Skipping the test in the absence of the SIPServer
code would be another option, but then you're skipping the test, and for
the sake of 1 constant, that seems like a bad trade.)

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/SIP.pm b/Open-ILS/src/perlmods/lib/OpenILS/SIP.pm
index a860910f49..37375064d3 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/SIP.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/SIP.pm
@@ -25,7 +25,6 @@ use OpenSRF::Utils qw/:datetime/;
 use DateTime::Format::ISO8601;
 use Encode;
 use Unicode::Normalize;
-use Sip::Constants qw(SIP_DATETIME);
 
 my $U = 'OpenILS::Application::AppUtils';
 
@@ -36,6 +35,11 @@ my $target_encoding;    # FIXME: this is configured at the institution level.
 
 use Digest::MD5 qw(md5_hex);
 
+# Copied from Sip::Constants
+use constant {
+    SIP_DATETIME => "%Y%m%d    %H%M%S",
+};
+
 sub new {
     my ($class, $institution, $login) = @_;
     my $type = ref($class) || $class;