From: erickson <erickson@dcc99617-32d9-48b4-a31d-7c20da2025e4>
Date: Fri, 26 Dec 2008 16:52:17 +0000 (+0000)
Subject: augmented penalty block list widget to automatically return the formated value
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=fe420fe12fb9782160c9eeb7f6174962fd0b685a;p=Evergreen.git

augmented penalty block list widget to automatically return the formated value

git-svn-id: svn://svn.open-ils.org/ILS/trunk@11680 dcc99617-32d9-48b4-a31d-7c20da2025e4
---

diff --git a/Open-ILS/web/js/ui/default/conify/global/config/standing_penalty.js b/Open-ILS/web/js/ui/default/conify/global/config/standing_penalty.js
index f8396594ab..f8ad62ded5 100644
--- a/Open-ILS/web/js/ui/default/conify/global/config/standing_penalty.js
+++ b/Open-ILS/web/js/ui/default/conify/global/config/standing_penalty.js
@@ -31,7 +31,7 @@ function spCreate(args) {
     var penalty = new csp();
     penalty.name(args.name);
     penalty.label(args.label);
-    penalty.block_list(formatBlockList(args.block_list)); 
+    penalty.block_list(args.block_list); 
 
     fieldmapper.standardRequest(
         ['open-ils.permacrud', 'open-ils.permacrud.create.csp'],
@@ -44,22 +44,10 @@ function spCreate(args) {
         }
     );
 }
-
-function formatBlockList(list) {
-    var str = '';
-    for(var idx in list)
-        str += list[idx] + '|';
-    return  str.replace(/\|$/, '');  
-}
-
 function spGridChanged(item, attr, oldVal, newVal) {
     var sp = spCache[spGrid.store.getValue(item, 'id')];
     console.log("changing cm " + sp.id() + " object: " + attr + " = " + newVal);
-    if(attr == 'block_list') {
-        sp[attr](formatBlockList(newVal));
-    } else {
-        sp[attr](newVal);
-    }
+    sp[attr](newVal);
     sp.ischanged(true);
     spSaveButton.setDisabled(false);
 }
@@ -121,15 +109,15 @@ function _deleteFromGrid(list, idx) {
 
     fieldmapper.standardRequest(
        ['open-ils.permacrud', 'open-ils.permacrud.delete.csp'],
-       {   async: true,
-           params: [openils.User.authtoken, id],
-           oncomplete: function(r) {
-           if(obj = openils.Util.readResponse(r)) {
-               spGrid.store.deleteItem(item);
-           }
-           _deleteFromGrid(list, ++idx);
-           }
-       }
+       {    async: true,
+            params: [openils.User.authtoken, id],
+            oncomplete: function(r) {
+                if(obj = openils.Util.readResponse(r)) {
+                    spGrid.store.deleteItem(item);
+                }
+                _deleteFromGrid(list, ++idx);
+            }
+        }
     );
 }
 
diff --git a/Open-ILS/web/templates/default/conify/global/config/standing_penalty.tt2 b/Open-ILS/web/templates/default/conify/global/config/standing_penalty.tt2
index 424b6e456b..22d6332e3f 100644
--- a/Open-ILS/web/templates/default/conify/global/config/standing_penalty.tt2
+++ b/Open-ILS/web/templates/default/conify/global/config/standing_penalty.tt2
@@ -19,6 +19,17 @@
                     this.addOption({value:'CIRC', label:'CIRC'});
                     this.addOption({value:'RENEW', label:'RENEW'});
                     this.addOption({value:'HOLD', label:'HOLD'});
+                },
+                attr : function(name, value) {
+                    if(name == 'value' && value == null) {
+                        var val = this.inherited('attr', arguments);
+                        var str = '';
+                        for(var i in val)
+                            str += val[i] + '|';
+                        return str.substring(0, str.length - 1);
+                    } else {
+                        return this.inherited('attr', arguments);
+                    } 
                 }
             } 
         );
@@ -66,7 +77,7 @@
                         cellType='dojox.grid.cells._Widget' widgetClass='dijit.form.TextBox'>Label</th>
                     <th field="block_list" width='auto' editable='true' 
                         cellType='dojox.grid.cells._Widget'
-                        widgetClass='openils.widget.StandingPenaltyBlockedSelector' jsId='formatBlockList'>Block List</th>
+                        widgetClass='openils.widget.StandingPenaltyBlockedSelector'>Block List</th>
                 </tr>
             </thead>
         </table>