From: Dan Wells <dbw2@calvin.edu>
Date: Thu, 22 Mar 2018 14:31:58 +0000 (-0400)
Subject: LP#1755502 Fix hold user test
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=refs%2Fheads%2Fcollab%2Fdbwells%2Flp1755502_fix_hold_user_test;p=working%2FEvergreen.git

LP#1755502 Fix hold user test

Now that we are fleshing this field, we need to dig a little deeper
for the 'id' to test if we are the same user.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
index 3f3d9461b1..c2d55186cf 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
@@ -1126,7 +1126,7 @@ sub check_captured_holds {
         ]
     )->[0];
 
-    if ($hold and $hold->usr == $patron->id) {
+    if ($hold and $hold->usr->id == $patron->id) {
         $self->checkout_is_for_hold(1);
         return undef;
     } elsif ($hold) {