From: Mike Rylander <mrylander@gmail.com>
Date: Thu, 9 Feb 2017 19:45:55 +0000 (-0500)
Subject: Adjust comment about apostrophes in opensearch code.  This is a marker for future... 
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=refs%2Fheads%2Fcollab%2Fgmcharlt%2Flp1005040_realign_search_layers;p=working%2FEvergreen.git

Adjust comment about apostrophes in opensearch code.  This is a marker for future work.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/SuperCat.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/SuperCat.pm
index a5997067bb..e9e34879de 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/SuperCat.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/SuperCat.pm
@@ -1437,9 +1437,10 @@ sub opensearch_feed {
 
     my $org_unit = get_ou($org);
 
-    # Apostrophes break search and get indexed as spaces anyway
-    # XXX ^that's kinda a lie ...
     my $safe_terms = $terms;
+
+    # XXX Apostrophes used to break search, but no longer do.  The following
+    # XXX line breaks phrase searching in OpenSearch, and should be removed.
     $safe_terms =~ s{'}{ }go;
     
     my $query_terms = 'site('.$org_unit->[0]->shortname.") $safe_terms";