From: Jason Etheridge <jason@EquinoxOLI.org>
Date: Mon, 28 Mar 2022 13:50:08 +0000 (-0400)
Subject: LP1901930 fix renewal counts and add AE msg type
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=refs%2Fheads%2Fcollab%2Fphasefx%2Fsipmbackend-finished-commits;p=working%2FEvergreen.git

LP1901930 fix renewal counts and add AE msg type

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm
index 4a7f51def0..150dedb3be 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2.pm
@@ -366,6 +366,7 @@ sub patron_response_common_data {
             fields => [
                 {AO => $session->config->{institution}},
                 {AA => $barcode},
+                {AE => ''},
                 {BL => $SC->sipbool(0)}, # valid patron
                 {CQ => $SC->sipbool(0)}  # valid patron password
             ]
@@ -395,6 +396,10 @@ sub patron_response_common_data {
         ],
         fields => [
             {AA => $barcode},
+            {AE => sprintf('%s %s %s',
+                   ($patron->first_given_name || ''),
+                   ($patron->second_given_name || ''),
+                   ($patron->family_name || ''))},
             {AO => $session->config->{institution}},
             {BH => $session->config->{settings}->{currency}},
             {BL => $SC->sipbool(1)},          # valid patron
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2/Checkout.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2/Checkout.pm
index ab3b73f9b1..77a6300ef3 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2/Checkout.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/SIP2/Checkout.pm
@@ -97,6 +97,7 @@ sub perform_checkout {
         my $textcode = $event->{textcode};
 
         if ($textcode eq 'SUCCESS' && $event->{payload}) {
+            $circ_details->{ok} = 1;
             if (my $circ = $event->{payload}->{circ}) {
                 $circ_details->{circ} = $circ;