From: Bill Erickson <berick@esilibrary.com>
Date: Tue, 4 Mar 2014 20:17:21 +0000 (-0500)
Subject: LP#1284864 propagate patron barcode to advanced hold options (repair)
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=refs%2Fheads%2Fuser%2Fberick%2Flp1284864-tpac-mr-formats-repairs-and-usability;p=working%2FEvergreen.git

LP#1284864 propagate patron barcode to advanced hold options (repair)

Signed-off-by: Bill Erickson <berick@esilibrary.com>
---

diff --git a/Open-ILS/src/templates/opac/parts/place_hold.tt2 b/Open-ILS/src/templates/opac/parts/place_hold.tt2
index effc45b875..1a497f7da8 100644
--- a/Open-ILS/src/templates/opac/parts/place_hold.tt2
+++ b/Open-ILS/src/templates/opac/parts/place_hold.tt2
@@ -27,7 +27,7 @@
                 [% l("Place hold for patron by barcode:") %]
             </label>
             <input type="text" name="hold_usr" id="hold_usr_input" 
-              value="[% CGI.param('staff_barcode') | html %]"
+              value="[% CGI.param('usr_barcode') | html %]"
               onchange="staff_hold_usr_barcode_changed();" 
               onpaste="setTimeout(staff_hold_usr_barcode_changed,1);" 
               onkeypress="return no_hold_submit(event)" autofocus /> 
@@ -36,7 +36,7 @@
               [% l('Patron barcode was not found') %]
             </span><br />
             <input type="hidden" id="staff_barcode" 
-              value="[% CGI.param('staff_barcode') || ctx.staff_recipient.card.barcode | html %]"/>
+              value="[% ctx.staff_recipient.card.barcode | html %]"/>
             <span>
                 <input type="radio" id="hold_usr_is_requestor"
                     onchange="staff_hold_usr_input_disabler(this);"
diff --git a/Open-ILS/web/js/ui/default/opac/staff.js b/Open-ILS/web/js/ui/default/opac/staff.js
index 8dd97fb522..8bae62f732 100644
--- a/Open-ILS/web/js/ui/default/opac/staff.js
+++ b/Open-ILS/web/js/ui/default/opac/staff.js
@@ -39,8 +39,11 @@ function staff_hold_usr_barcode_changed(isload) {
         var barcode = isload;
         if(!barcode || barcode === true) barcode = document.getElementById('staff_barcode').value;
         var only_settings = true;
+        var bc_from_cgi = false; // user_barcode passed via cgi
         if(!document.getElementById('hold_usr_is_requestor').checked) {
-            if(!isload) {
+            if (isload && document.getElementById('hold_usr_input').value)
+                bc_from_cgi = true;
+            if(!isload || bc_from_cgi) {
                 barcode = document.getElementById('hold_usr_input').value;
                 only_settings = false;
             }
@@ -108,13 +111,13 @@ function staff_hold_usr_barcode_changed(isload) {
         var adv_link = document.getElementById('advanced_hold_link');
         if (adv_link) { // not present on MR hold pages
             var href = adv_link.getAttribute('href').replace(
-                /;staff_barcode=[^;\&]+|$/, 
-                ';staff_barcode=' + encodeURIComponent(cur_hold_barcode));
+                /;usr_barcode=[^;\&]+|$/, 
+                ';usr_barcode=' + encodeURIComponent(cur_hold_barcode));
             adv_link.setAttribute('href', href);
         }
 
-        // Ok, now we can allow submitting again, unless this is a "true" load, in which case we likely have a blank barcode box active
-        if (isload !== true)
+        // if we're here, we have a valid barcode.  activate the sumbmit option
+        if(!isload || bc_from_cgi) 
             document.getElementById('place_hold_submit').disabled = false;
     }
 }