From: Bill Erickson <berickxx@gmail.com>
Date: Mon, 29 Dec 2014 22:05:39 +0000 (-0500)
Subject: LP#1406367 Fine generator skips no-fines transactions (parallel)
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=refs%2Fheads%2Fuser%2Fberick%2Flp1406367-fine-generator-bloat-control;p=working%2FEvergreen.git

LP#1406367 Fine generator skips no-fines transactions (parallel)

Avoid inspecting no-fines transactions when running the fine generator
in parallel mode.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
index 56ad4a84f4..b619711e0d 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
@@ -311,7 +311,8 @@ sub grab_overdue {
 
     my $idlist = $self->api_name =~/id_list/o ? 1 : 0;
     
-    $client->respond( $idlist ? $_ : $_->to_fieldmapper ) for ( overdue_circs('', $idlist) );
+    $client->respond( $idlist ? $_ : $_->to_fieldmapper ) 
+        for ( overdue_circs('', $idlist, undef, 1) );
 
     return undef;
 
@@ -324,7 +325,8 @@ __PACKAGE__->register_method(
     signature       => q/
         Return list of overdue circulations and reservations to be used for fine generation.
         Despite the name, this is not a generic method for retrieving all overdue loans,
-        as it excludes loans that have already hit the maximum fine limit.
+        as it excludes loans that have already hit the maximum fine limit
+        and transactions which do not accrue fines.
 /,
 );
 __PACKAGE__->register_method(