From: Chris Sharp <csharp@georgialibraries.org>
Date: Sun, 7 Feb 2021 20:02:26 +0000 (-0500)
Subject: LP#1229794: Remove unused parameter from invalidate patron data API
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=refs%2Fheads%2Fuser%2Fcsharp%2Flp1229794_remove_unused_param;p=working%2FEvergreen.git

LP#1229794: Remove unused parameter from invalidate patron data API

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
index bbe57e29a2..d0ccf3a1aa 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
@@ -4973,7 +4973,6 @@ __PACKAGE__->register_method(
         params => [
             {desc => "Authentication token", type => "string"},
             {desc => "Patron ID (optional if Email address specified)", type => "number"},
-            {desc => "Additional note text (optional)", type => "string"},
             {desc => "penalty org unit ID (optional)", type => "number"},
             {desc => "Email address (optional)", type => "string"}
         ],
@@ -4989,7 +4988,6 @@ __PACKAGE__->register_method(
         params => [
             {desc => "Authentication token", type => "string"},
             {desc => "Patron ID (optional if Phone Number specified)", type => "number"},
-            {desc => "Additional note text (optional)", type => "string"},
             {desc => "penalty org unit ID (optional)", type => "number"},
             {desc => "Phone Number (optional)", type => "string"}
         ],
@@ -5005,7 +5003,6 @@ __PACKAGE__->register_method(
         params => [
             {desc => "Authentication token", type => "string"},
             {desc => "Patron ID (optional if Phone Number specified)", type => "number"},
-            {desc => "Additional note text (optional)", type => "string"},
             {desc => "penalty org unit ID (optional)", type => "number"},
             {desc => "Phone Number (optional)", type => "string"}
         ],
@@ -5021,7 +5018,6 @@ __PACKAGE__->register_method(
         params => [
             {desc => "Authentication token", type => "string"},
             {desc => "Patron ID (optional if Phone Number specified)", type => "number"},
-            {desc => "Additional note text (optional)", type => "string"},
             {desc => "penalty org unit ID (optional, default to top of org tree)",
                 type => "number"},
             {desc => "Phone Number (optional)", type => "string"}
@@ -5031,7 +5027,7 @@ __PACKAGE__->register_method(
 );
 
 sub mark_users_contact_invalid {
-    my ($self, $conn, $auth, $patron_id, $addl_note, $penalty_ou, $contact) = @_;
+    my ($self, $conn, $auth, $patron_id, $penalty_ou, $contact) = @_;
 
     # This method invalidates an email address or a phone_number which
     # removes the bad email address or phone number, copying its contents
@@ -5056,8 +5052,7 @@ sub mark_users_contact_invalid {
     }
  
     return OpenILS::Utils::BadContact->mark_users_contact_invalid(
-        $e, $contact_type, $howfind,
-        $addl_note, $penalty_ou, $e->requestor->id
+        $e, $contact_type, $howfind, $penalty_ou, $e->requestor->id
     );
 }
 
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Utils/BadContact.pm b/Open-ILS/src/perlmods/lib/OpenILS/Utils/BadContact.pm
index 28ee239d62..262d405fff 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Utils/BadContact.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Utils/BadContact.pm
@@ -19,8 +19,7 @@ our $PENALTY_NAME_MAP = {
 
 sub mark_users_contact_invalid {
     my (
-        $class, $editor, $contact_type, $howfind,
-        $addl_note, $penalty_ou, $staff_id
+        $class, $editor, $contact_type, $howfind, $penalty_ou, $staff_id
     ) = @_;
 
     if (not ref $howfind eq "HASH") {
diff --git a/Open-ILS/web/js/ui/default/actor/user/register.js b/Open-ILS/web/js/ui/default/actor/user/register.js
index 0e9ae91a54..abcaefff67 100644
--- a/Open-ILS/web/js/ui/default/actor/user/register.js
+++ b/Open-ILS/web/js/ui/default/actor/user/register.js
@@ -2111,7 +2111,7 @@ function uGenerateInvalidatorWidget(container_node, field) {
                 fieldmapper.standardRequest(
                     ["open-ils.actor", "open-ils.actor.invalidate." + field], {
                         "async": true,
-                        "params": [openils.User.authtoken, patron.id(), null, patron.home_ou()],
+                        "params": [openils.User.authtoken, patron.id(), patron.home_ou()],
                         "oncomplete": function(r) {
                             progressDialog.hide();
                             // alerts on non-success event
diff --git a/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js b/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js
index 0d6394db55..bef535b3c5 100644
--- a/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js
+++ b/Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js
@@ -644,7 +644,7 @@ angular.module('egCoreMod')
         return egCore.net.request(
             'open-ils.actor',
             'open-ils.actor.invalidate.' + field,
-            egCore.auth.token(), patron.id, null, patron.home_ou.id()
+            egCore.auth.token(), patron.id, patron.home_ou.id()
 
         ).then(function(res) {
             // clear the invalid value from the form