From: Dan Wells <dbw2@calvin.edu>
Date: Wed, 17 Aug 2016 15:55:32 +0000 (-0400)
Subject: LP#1228392 Allow mapped fields to show up in reporter template builder
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=refs%2Fheads%2Fuser%2Fdbwells%2Flp1228392_allow_mapped_fields_in_reporter;p=working%2FEvergreen.git

LP#1228392 Allow mapped fields to show up in reporter template builder

Since inception, mapped fields have been hidden in the reporter, the
logic being that showing them shows too much (in particular, a circular
reference back to ourselves), and is therefore confusing.

However, not showing them means we have two options:
1) Don't use those fields in the reporter.
2) Add a second, non-mapped field just for the reporter.

These options both seem less than ideal, so for now, just let them
show up, and let the user sort it out.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
---

diff --git a/Open-ILS/web/reports/xul/source-browse.js b/Open-ILS/web/reports/xul/source-browse.js
index 0442e3a7dc..79bfbd627b 100644
--- a/Open-ILS/web/reports/xul/source-browse.js
+++ b/Open-ILS/web/reports/xul/source-browse.js
@@ -45,7 +45,11 @@ function sourceTreeHandler (ev, dbl) {
 				var key = link_fields[i].getAttribute('key');
 				var reltype = link_fields[i].getAttribute('reltype');
 
-				if (map) continue;
+				// We could give up here, do something smart (TBD) or
+				// let the user deal with the complexity manually
+				//
+				// For now, option #3
+				//if (map) continue;
 
 				var pathList = [];
 				findAncestorStack( item, 'treeitem', pathList );