From: Jason Stephenson <jason@sigio.com>
Date: Mon, 22 Oct 2012 14:05:32 +0000 (-0400)
Subject: Fix handling of ranges in OpenILS::SIP::Patron::fine_items().
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=refs%2Fheads%2Fuser%2Fdyrcona%2Flp1069833;p=working%2FEvergreen.git

Fix handling of ranges in OpenILS::SIP::Patron::fine_items().

When the client specifies a begin and end range for SIP2 fine items,
only the first fine item is returned. This is because of a typo on
line 646. The @fines array should be dereferenced there as @fines and
not $fines.

Signed-off-by: Jason Stephenson <jason@sigio.com>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
index 4a77bd0962..9299738ed9 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
@@ -643,7 +643,7 @@ sub fine_items {
     my $log_status = $@ ? 'ERROR: ' . $@ : 'OK';
     syslog('LOG_DEBUG', 'OILS: Patron->fine_items() ' . $log_status);
     return (defined $start and defined $end) ? 
-        [ $fines[($start-1)..($end-1)] ] : \@fines;
+        [ @fines[($start-1)..($end-1)] ] : \@fines;
 }
 
 # not currently supported