From: Galen Charlton <gmc@equinoxinitiative.org>
Date: Wed, 22 Mar 2017 16:25:41 +0000 (-0400)
Subject: LP#1668720: remove browser console noise for OPAC
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=refs%2Fheads%2Fuser%2Fgmcharlt%2Flp1668720_client_tz_console_noise;p=working%2FEvergreen.git

LP#1668720: remove browser console noise for OPAC

This patch fixes a case where JavaScript used in the OPAC
attempts to set the value of a #client_tz_id input on all
pages, even though only the login page has such an input.

To test:

[1] Load the OPAC homepage and open the JavaScript console/developer tools.
    Note that there's a "Cannot set property 'value' of null"
    error.
[2] Apply the patch and try again; this time there shouldn't
    be such an error.
[3] Open the login page, and verify, using developer tools,
    that the hidden client_tz_id input does have its value
    set to the client timezone.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
---

diff --git a/Open-ILS/src/templates/opac/parts/js.tt2 b/Open-ILS/src/templates/opac/parts/js.tt2
index 245af4347a..4d5b400f31 100644
--- a/Open-ILS/src/templates/opac/parts/js.tt2
+++ b/Open-ILS/src/templates/opac/parts/js.tt2
@@ -152,5 +152,5 @@ var aou_hash = {
   </script>
 [% END %]
 
-<script type="text/javascript">$('client_tz_id').value = OpenSRF.tz</script>
+<script type="text/javascript">if ($('client_tz_id')) { $('client_tz_id').value = OpenSRF.tz }</script>
 [%- END; # want_dojo -%]