From: Jeff Godin <jgodin@tadl.org>
Date: Thu, 19 Jun 2014 16:27:38 +0000 (-0400)
Subject: Add ISBN to SIP CH field
X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=refs%2Fheads%2Fuser%2Fjeff%2Funtested_poc_sip_item_isbn;p=working%2FEvergreen.git

Add ISBN to SIP CH field

Untested proof of concept sparked by a conversation on IRC.

I don't know if the ISBN even belongs in CH or if it should be
placed elsewhere.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
---

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Item.pm b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Item.pm
index a2523e11a9..2ca27fd3d1 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Item.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Item.pm
@@ -320,6 +320,15 @@ sub title_id {
     return OpenILS::SIP::clean_text($t);
 }
 
+# XXX: Untested proof of concept
+# I make no claims as to if CH / FID_ITEM_PROPS is the proper place to include an ISBN
+# Using tagging logic from the draft SIP3 standard's ID field here
+sub sip_item_properties {
+    my $self = shift;
+    my $isbn = ($self->{mods}) ? $self->{mods}->isbn : $self->{copy}->dummy_isbn;
+    return OpenILS::SIP::clean_text('ISBN:' . $isbn);
+}
+
 sub permanent_location {
     my $self = shift;
     return OpenILS::SIP::clean_text($self->{copy}->circ_lib->shortname);