From: Mike Rylander Date: Mon, 2 Apr 2018 20:09:12 +0000 (-0400) Subject: LP#1760223: Update HTTP headers to follow standard X-Git-Url: https://old-git.evergreen-ils.org/?a=commitdiff_plain;h=refs%2Fheads%2Fuser%2Fmiker%2Flp-1760223-download-exported-records;p=working%2FEvergreen.git LP#1760223: Update HTTP headers to follow standard In the olden days, some browsers didn't understand the "attachment" content disposition. They only understood "inline" but would let the user save a file if a filename was provided. However, in these modern days, relevant browsers all do the right thing and know about both flavors of content disposition, so we, too, must change with the times and support the letter of the standard. This commit fixes downloading of MARCXML from the Exporter module. Signed-off-by: Mike Rylander --- diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/Exporter.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/Exporter.pm index bf2fa367ca..8508ab6ede 100644 --- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/Exporter.pm +++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/Exporter.pm @@ -180,7 +180,7 @@ sub handler { } - $r->headers_out->set("Content-Disposition" => "inline; filename=$filename"); + $r->headers_out->set("Content-Disposition" => "attachment; filename=$filename"); if (uc($format) eq 'XML') { $r->content_type('application/xml');