remove deprecated code

Signed-off-by: Bill Erickson <berickxx@gmail.com>

eager global ordinals on facet fields

Signed-off-by: Bill Erickson <berickxx@gmail.com>

boost and score sorting repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Better defined node unique constraint

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Identifier searches / isbn issn normalizers

Signed-off-by: Bill Erickson <berickxx@gmail.com>

misc tidying and docs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

more docs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

more docs, query clensing

Signed-off-by: Bill Erickson <berickxx@gmail.com>

move away from mapper to pure client

Signed-off-by: Bill Erickson <berickxx@gmail.com>

exact/prefix searches continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

elastic service continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

elastic-builder / marc search

Signed-off-by: Bill Erickson <berickxx@gmail.com>

elastic-builder in action

Signed-off-by: Bill Erickson <berickxx@gmail.com>

elastic bib field IDL class mod

Signed-off-by: Bill Erickson <berickxx@gmail.com>

more catalog integration experiements / elastic-builder

Signed-off-by: Bill Erickson <berickxx@gmail.com>

tighter catalog integration WIP

Signed-off-by: Bill Erickson <berickxx@gmail.com>

tighter catalog integration WIP

Signed-off-by: Bill Erickson <berickxx@gmail.com>

initial tighter catalog integration / cat side needs more data

Signed-off-by: Bill Erickson <berickxx@gmail.com>

add label to bib_fields list

Signed-off-by: Bill Erickson <berickxx@gmail.com>

additional index tidying

Signed-off-by: Bill Erickson <berickxx@gmail.com>

additional index tidying

Signed-off-by: Bill Erickson <berickxx@gmail.com>

initial support multiple lang analyzers; multi_match queries

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Updated example search in test script

Signed-off-by: Bill Erickson <berickxx@gmail.com>

add marc data to bib search index

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Consolidate some indexing code

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib marc record index / searching

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib marc record index / searching

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib marc record index

Signed-off-by: Bill Erickson <berickxx@gmail.com>

support es proxied path; indexes one at a time

Signed-off-by: Bill Erickson <berickxx@gmail.com>

data sync continued / _id fix

Signed-off-by: Bill Erickson <berickxx@gmail.com>

working on data sync

Signed-off-by: Bill Erickson <berickxx@gmail.com>

disabled marc indexer experiment

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Remove some TODO comments: done

Signed-off-by: Bill Erickson <berickxx@gmail.com>

EL sample config superseded by per-index definitions

Signed-off-by: Bill Erickson <berickxx@gmail.com>

force-on ang7 cat for now

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Avoid huge index values

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Log first/last bib ID of each indexed batch

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Indexer orders by ID for batch consistency

Signed-off-by: Bill Erickson <berickxx@gmail.com>

indexer start-date support

Signed-off-by: Bill Erickson <berickxx@gmail.com>

ES gets child init

Signed-off-by: Bill Erickson <berickxx@gmail.com>

copy loc/stat filters

Signed-off-by: Bill Erickson <berickxx@gmail.com>

copy loc/stat filters wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Group searches OR-based; lower kw normalizer

Signed-off-by: Bill Erickson <berickxx@gmail.com>

QP comp continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

ang6 catalog use correct search_format filter

Signed-off-by: Bill Erickson <berickxx@gmail.com>

QP based query compilation

Signed-off-by: Bill Erickson <berickxx@gmail.com>

search_format filter; logging

Signed-off-by: Bill Erickson <berickxx@gmail.com>

facets continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Indexer improvements, docs, and options

Signed-off-by: Bill Erickson <berickxx@gmail.com>

facets, etc.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

el conf idl fields, etc.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

use existing indexed values; refactoring

Signed-off-by: Bill Erickson <berickxx@gmail.com>

use existing indexed values

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib-search indexing; search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib-search indexing; search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib-search indexing; search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

json config for now; index create/delete

Signed-off-by: Bill Erickson <berickxx@gmail.com>

ES/EG SQL

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1845706 (follow-up): Fix callback

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>

LP#1845706: Missing/Damaged from Items Out

Marking items Missing or Damaged from the patron Items Out interface
is sometimes necessary.  This commit adds that ability.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>

LP#1863386: link ADMIN_CAROUSEL permission to appropriate OU context

This patch restricts prcrud retrieval and modification of templates
to users who have ADMIN_CAROUSEL in the relevant carousel owner OU
rather than requiring global_required.

To test
-------
[1] Apply the patch.
[2] Ensure that a user with ADMIN_CAROUSEL privileges at a depth
    lower than "Consortium" can only view and edit carousel
    definitions at OUs applicable to their working libraries.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxinitiative.org>

LP#1839684: avoid repeating qtype prefix in query

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>

LP1854197 Add Vols and Copies honors owning lib

Fixes a bug in the Add Volumes and Copies action where there vol/copy
editor was unable to extract the owning library of the selected volumes,
thus leading to no differentation between owning libraries in the editor
and having all of the new volumes/copies linked (by default) to the
first owning library in the list.

To test:

1. Navigate to Item Status UI
2. Scan multiple (say, 3) barcodes, each with a different owning lib.
3. Select all 3 items and chose "Add Callnumbers and Items"
4. The holdings edit page that results should show one volume and copy
   row per owning library instead of all rows linked to the first owning
   library in the set.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jessica Woolford <jwoolford@biblio.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1849736 Add action trigger for email/sms for patron self registration

Removed double blank lines at the top of the stock AT Email template.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1849736 Add action trigger for email/sms for patron self registration

Setup a new A/T Hook.

Includes:
1. New row in action_trigger.hook
2. New row in action_trigger.event_definition
3. New clause in action_trigger_filters.json.example
4. Link XML clause for oils_obj:fieldmapper="staging::user_stage" on fm_IDL.xml
4. pgTAP Test
5. Release Documentation

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1761222: Replace bib "quality" with item "mint_condition"

I originally misunderstood the XUL item field labeled "quality" and
pulled in the bib record "overall quality" score. But upon checking the
XUL holdings maintenance screen again, we clearly want the item's
"mint_condition" field instead. This commit makes that correction and
converts the 't' or 'f' values into "Good" or "Damaged", to match the
item editor labels.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1761222 Holdings batch circ retrieval

Fetch non-checked-in circulations for copies in the Holdings
maintenance grid (for due date display) in batch instead firing a
potentially vary large parallel batch of pcrud API calls.

This also limits due date display to items that have open circulations,
consistent with the XUL client.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1761222: Add four columns available in XUL client

The XUL client had these columns but they hadn't been added to the web client
yet. This commit adds them:

  - Classification
  - Due Date
  - OPAC visible?
  - Quality

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1761222: Add Fine Level, Loan Duration to Holdings View grid

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

lp1760193 - Action Rewording

- Rename "Add Items to Bucket/Record Bucket" and
"Add Items/Item Records to Bucket" to "Add to Item/Record
Bucket"

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
modified:   Open-ILS/src/templates/staff/cat/item/index.tt2
modified:   Open-ILS/src/templates/staff/cat/item/t_list.tt2

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

lp1760193 Add to Record Bucket from Item Status

- Add "Add Items to Record Bucket" option in Item Status
UI
- Refactor Add Copy to Bucket functionality to support
adding to Copy Buckets or to Record Buckets depending
on optional bucket_type parameter

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/cat/item/index.tt2
modified:   Open-ILS/src/templates/staff/cat/item/t_list.tt2
modified:   Open-ILS/web/js/ui/default/staff/cat/item/app.js
modified:   Open-ILS/web/js/ui/default/staff/circ/services/item.js

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1850546 Record detail shelf browse

Adds support for browsing call numbers directly from a record detail
page, similar to the TPAC's 'Shelf Browser' tab in its detail page.

Add support for jumping to a record detail page or a new author search
from each shelf browse entry.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@gmail.com>

LP1850546 Call number browse grid

Return to grid-shaped call number browse with denser data display for
main CN browse UI.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@gmail.com>

LP1859241 Relase Notes (Angular Patron Search)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@gmail.com>

LP1859241 Angular holds patron search dialog

Implements a patron search dialog which may be instantiated directly
from the staff catalog holds placement interface.

Includes:

1. New patron module (which absorbs the existing PatronService)
2. New patron search component
3. Patron search component dialog wrapper.
4. Patron profile selector component which understands custom group
   display trees.
4. Fixes an issue with the grid where the 'datatype' was not always
   propagated to IDL fields.
5. Modifies the combobox to allow the caller to clear the value by
   passing a null value for the selectedId.

To Test:

[1] Navigate to the Angular staff catalog
[2] Perform a bib search
[3] Click 'Place Hold' next to a title.
[4] Click the 'Patron Search' button.
[5] Search for patrons and either double-click a search result row or
    single click then chose the 'Select' button.
[6] Confirm the selected patron is now chosen for holds placement.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@gmail.com>

LP1860044 Release Notes for Ang Cat Highlights

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@gmail.com>

LP1860044 Angular catalog search result highlights

Support search field highlighting in the Angular staff catalog
search result and record detail pages.

Adds a new <eg-bib-display-field /> component for rendering the
highlighted content.

Move the catalog-common module import into the staff common module so
the bib-summary component has access to the new display-field component.

Drop the default search result page size to 10 for consistency with
other catalogs (and to speed up rendering).  Note users can still set
the page size of their choice via user settings.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@gmail.com>

LP1841823 Marc flat editor repair slashes (AngJS)

Replace all control field spaces with backslashes in MARC Flat text
editor (AngJS edition).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>

LP1841823 Marc flat editor repair slashes (Angular)

Replace all control field spaces with backslashes in MARC Flat text
editor, Anglular edition.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>

LP1859706 Map Angular cat "Patron View" to AngJS "OPAC View"

The Angular catalog now treats the "Patron View" tab as the same as
the "OPAC View" tab in the AngJS catalog for the purposes of saving a
preferred default tab.

Similarly, the Angular catalog-only "Item Table" tab maps to the AngJS
"OPAC View" tab, since it's the closest analog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@gmail.com>

LP1819236 Ang cat prevent keyword starts/exact searches

Prevent users from attempting Keyword starts-with or matches-exactly
searches since these are nonsensical.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@gmail.com>

LP1860275 Staff catalog add mono part repair

Fixes a bug in the New Monograph Part dialog which prevented passing the
bib record ID during the creation process, which resulted in a database
error and faulure to create the part.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

LP1850938 Stamping DB upgrade (Ang Cat Prefs)

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1850938 Angular Catalog Prefs Release Notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP1850938 Angular Catalog Preferences Page

Adds a new "Catalog Preferences" interface, accessible directly from the
catalog.  The UI houses the search preferences (default search lib,
preferred library, default search tab), a new staff-specific
hits-per-page setting.  Other preferences may be added later.

Adds support for selecting a default search tab using the existing
'eg.search.adv_pane' setting.

Reduce API call count by loading more of the catalog preference settings
in the main batch invoked by the page resolver.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP1852782 Improve MARC edit save/delete button placement

Move the Save Record button to the left of the Delete Record, which is
more consistent with other yes/no button combinations in the client.
Also adds additional spacing and a faint border between the two buttons.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1852782 Fix Firefox contenteditable tabbing

Use tabindex="0" instead of tabindex="" to indicate focusable content.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1852782 Angular MARC record update API repairs

Use the correct API when updating authority records.

Also use the correct bib record update API per LP 1859191.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1852782 Linker links to auth record editor

Adds a new UI at /staff/cat/authority/edit/ for finding authority
records by ID and editing authority records via the Angular MARC editor.

Modifies the "Cataloging" => "Retrieve Authority Record By ID" nav menu
entry to point to the Angular version of the interface.

Augments the MARC edit authority linking dialog to turn authority ID's
into links which open the authority record in its own MARC editor in a
new tab.

Misc. MARC editor repairs related to loading authority records by ID.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1852782 Main entry link sets subfield 0

In the MARC editor, when applying a main entry heading, set the subfield
0 of the modified bib field to link to the authority record in question.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1852782 More title attributes for action buttons

Adds title attributes to the Phys Char wizard and authority linking
buttons, which contain no text within the button proper.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1852782 Vandelay MARC editor module repair

With the addition of Fast Add item support, the MARC editor requires
access to the HoldingsModule, which was not importe directly into
Vandelay, unlike the catalog.  This patch tells the MARC editor to
import the module itself.

Fixes:

QueuedRecordComponent.html:22
NullInjectorError: StaticInjectorError(BaseModule)[MarcEditorComponent
-> HoldingsService]:
  StaticInjectorError(Platform: core)[MarcEditorComponent ->
  HoldingsService]:
      NullInjectorError: No provider for HoldingsService!

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>