Fix for LP bug #702422.

Add @libdir@/javascript/ path in legacy script section of
oils_sip.xml.example so that legacy scripts work with SIP2.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Adding org unit context selector to providers screen
This helps alleviate the bug reported in LP 731510 and
generally improves usability.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Clear org_unit cache fix for autogen.sh

autogen.sh is not properly clearing the org_tree cache.  It is
unclear how this hasn't caused a problem before, but this fix
works for me and should be at least harmless in other enviroments.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Update 2.0-2.1 upgrade script to work from 2.0.9

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Pull in custom.js with offline/chrome overlays

Or at least try to.  Main goal here is for browser.xul to see url constant
changes from custom.js and feed them to embedded Acquisition interfaces via
xulG.urls

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Repaired field name thinko for config.record_attr_index_norm_map

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Hourly fine periods do not charge enough

Hourly fine periods are not charging for the first period of
overdue-ness. If an item is due at 2:00pm and has a fine of
$.50 per hour, the first fine should be eligible for generation
at 2:01pm. As it stands, the first fine does not generate until
an entire fine period has elapsed, so in this case, 3:00pm.

The previous version of the code had a special case for day-
granular fine periods, so a majority of fines were not affected.
This commit expands the same idea (charging for the fine period
you are currently "in") to all fine periods.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script for LP#837566

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#837566 undeleting a bib record causes an error

fixes a column reference

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

fix Acq -> Update Barcodes post-parts

Items from acquisitions were having null instead of [] for .parts()

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

LP#838969 Silent print cannot be unselected

Thanks Bill!

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

LP#824257 Fix nasty overlapping when patron has more than 6 notes

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Push phrases down to be subqueries, so they can be ORed together

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Correct make target for lucid

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Protect against div-by-0 for negated words

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Track count of dummy atoms and use a NULL tsquery when all dummy

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Use unphrases in SQL generation

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

add "unphrases" to capture negated phrases ( -"foo bar" ) and make the negator configurable

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Ignore empty atoms in query decomposition

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

2.[01]-stamped upgrade script for LP#816131

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Reverse direction of org_unit_ancestors

Apparently callers expect it to start at the top of the org tree.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Unwrapped upgrade script for oua_force_order

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

New version of actor.org_unit_ancestors

Preserves order through joins

Basically actor.org_unit_ancestors_distance with a join to get the
entire org units, rather than just IDs and a distance.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fixed seaching for a colon (:) surrounded by white space

When searching for a colon surrounded by white space the search would
freeze.  An example of such a search would be:
Climate change economics and policy : an RFF anthology
This was happening because the decompose function within QueryParser.pm
Would build a regular expression that would search the query for both
classes and class aliases e.g (keyword and kw).  However, when buliding
the regex for aliases QueryParser would add extraneous or symbols (|)
to the end of the regex without adding the accompanying alias.
This was happening because there was a check to see if the corresponding
class to each alias had already been added to the regex.  But, the
check to see if the alias had already been appened to the regex happened
too late.  I have moved the check to encopase the appending of the or
symbols and the class.
Signed-off-by: Liam Whalen <lwhalen@evergreen-dev.catalogue.nrcan.gc.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Branchify patch for LP bug #802523 for rel_2_1.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fix penalty generation during billing creation

by passing the editor object referencing the database transaction to xact_org

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Further upgrade script cleanup: address hold matrix DDL/DML ordering; use code instead of id for permission addition; include recent updates for lasso visiblity

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Display only available formats for metarecord holds in IE

The OPAC's usual hideMe()/unHideMe() tricks don't work for <option>
elements in Internet Explorer 8.  Use the disabled attribute.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Addressing some more upgrade script issues spotted by Ben Shum

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Addressing upgrade script issues spotted by Robert Soulliere in LP#828032

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Vandelay: repair item attr context org selector

1. Prevents resetting the context selector to the workstation org unit
each time it's changed.

2. Prevent the unintentional pileup of dojo.connect() events, which
can lead to exponential growth in the number of server calls to fetch
import-item-attribute-definitions with each change of the context org
selector.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

#LP801961, error when running edi_fetcher.pl

This patch addresses an error encountered when running edi_fetcher.pl.
The method "is_dir" should be just plain "dir" in RemoteAccount.pm file.
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Branchify second patch from James Fournie on LP bug #791941.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Branchify first patch from James Fournie on LP bug #791941.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Branchify patch from LP bug #809478 and forward port to rel 2.1.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Improve Vandelay Import/Merge Checkbox Labels

Since these labels are used both for the initial import and also
for imports from the queue, the use of the word "Auto" can be
confusing and misleading.  This commit reflects changes already
made in trunk for these labels.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fix importing of 'No Match' records from a queue

This small change honors the 'No Match' checkbox when importing
from a queue.

This bug has existed for a while, but was only recently exposed
by 06e4d3370068002a303c9a5a03448ee0e1249fc0.  Before that commit,
no-match records always imported, even when you didn't want them.
After that commit, they import when wanted on the initial load,
but could not be imported from the queue.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stricter order for actor.org_unit_parent_protect()

actor.org_unit_parent_protect() may not work due to the fact
that 'IF' conditions in PL/pgSQL are not necessarily processed
in the order written. This line:

"IF TG_OP = 'INSERT' OR NEW.parent_ou
IS DISTINCT FROM OLD.parent_ou THEN"

may fail because the 'IS DISTINCT FROM' happens before the
'INSERT' check, and and that fails because there is no 'OLD'
variable for INSERTs.

This commit may not be the optimal style for this circumstance
in this language, but it works.  It also appears to change more
than it really does due to a loss of one level of indentation in
the structure.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Whitespace Only Changes

Files uses primarily tabs, function used both spaces and tabs.
It now uses all tabs.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

LP 799719: Pass the DESTDIR variable to python installer

Based on Ben Webb's patch, but using the same triple-slash to avoid any
possibility of confusion about the installation location (see also the
same adjustment made to OpenSRF).

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Stamped upgrade scripts for LP#790329

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#790329 org_lasso search is broken

Fix the JavaScript error when we attempt to create a feed for the
shortname of the org_unit_lasso (lassos have no shortname) - which lets
the request hit the backend Perl module, which in turn chokes on a test
for OU that only allows two conditions: either all digits is treated as
a numeric ID for an org unit, or it is a shortname. Of course, lassos
are negative integers, so we have to modify the test slightly to make it
happier.

There was no depth for org lasso copy counts, and this was handled
correctly in the main case by the asset.opac_lasso_record_copy_count()
function and its staff variant, but when a copy was not found at a given
org_unit in the lasso a request was made for the non-existent depth and
the function would error out.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Placeholder for 2.0-only LP#790329 fix

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Keep the logging output of the EDI translator by default

There is valuable troubleshooting information there that is otherwise hard to
find.  This particularly matters when the output of an EDI
Action/Trigger template (JEDI) doesn't successfully get translated to
EDIFACT for nonobvious reasons.

In production environments, you might instead pipe to logger so that you can
collect output with syslog, rather than in a flat file.  As long as
output goes *somewhere.*

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

LP#820409 fix org unit admin UI

This reverts part of 17e659eec3e23caf5d301b33aa5019b672ecd0e8, which was
tightening checks against null and '' to avoid implicit type-casting.

This line var modified_ou = new aou().fromStoreItem( current_ou ); was
producing a fieldmapper object where certain fields were being set to
contain the string "undefined" rather than a null.

The update method would take isdeleted == "undefined" as True.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamped upgrades for LP#825303

Signed-off-by: Mike Rylander <mrylander@gmail.com>

return only the one applicable OU setting value

Correct actor.org_unit_ancestor_setting so that it returns
at most one setting value, rather than the entire set
 of values defined for the OU and its ancestors.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

lp#825303: fix cat.default_classification_scheme lookup

Fixes a bug where the wrong default classification scheme
could be chosen when adding a new volume whose classification
scheme was not explicitly set.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Upgrade script (based on 2.0.8, currently)

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamped upgrade script for "lp 823496: do not fail to index personal names that have relators"

Signed-off-by: Mike Rylander <mrylander@gmail.com>

lp 823496: don't fail to index personal names that have relators

The default definition for the author|other index inadvertantly
excluded names from 600, 700, 720, and 800 fields that have
relator values ($e) or codes ($4).

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Don't escape_html numbers in util/print.js

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Escape HTML characters in template subs

This prevents injection of random HTML from various sources.

Like bad bib records, org unit settings, patron info, etc.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Use openDialog to make go_print workaround vanish

By passing params and the go_print function into openDialog we get
to ignore race conditions, as the window is created with the passed
in arguments.

Oh, and we can stop using js2JSON and such.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Add openDialog to window class

Uses window.openDialog instead of window.open.
https://developer.mozilla.org/en/DOM/window.openDialog

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

No more lightpink for disabled copy editor

Folks can still provide custom CSS against those class hooks if desired

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

in lieu of Ready Item Editor

We're trying to prevent folks from using the item attribute editor in the
unified interface when the volume pane is still updating its information
(i.e. building the copies to feed to the attribute editor), so that a
given editing widget isn't ripped out from under staff while its being
used.  This change removes the heavy-handed Ready Item Editor button and
instead tries to more gracefully manage the editor state based on change
and keypress events.  Also change the color scheme for a disabled editor
from red to light pink.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fix stop sign page race condition with checkout

This would happen most often when retrieving multiple patrons at the same time
from patron search--the stop sign page would show but then get trampled by the
checkout interface, which normally loads first.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Merge branch 'rel_2_1' of git.evergreen-ils.org:Evergreen into rel_2_1

Whoops. Do that availability test regard of whether hold_boundaries are used.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

In a middle-layer method for returning holdable formats on a metarecord,

Do a better test of copy holdability than we were doing previously.
We can't do a perfect test: we don't really know what patron we're doing
this for, and even if we did, from here it's nontrivial to figure out
whether we're doing indb holds or script-based, much less run the tests.

Still, we can test whether a copy's in a holdable status, a holdable
location, and is itself not explicitly marked unholdable.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

mrpeters caught this; wrong variable fed to error dialog

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Repaired copy private/public note vandelay bug

Previously, all copy notes imported through vandelay were coming in as
public copy notes.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Stamped upgrade script for ACQ_INVOICE_REOPEN permission addition

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Upgrade script for LP818311 branch.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#818311:  ACQ_INVOICE_REOPEN is missing

This patch adds the missing ACQ_INVOICE_REOPEN to the Acquisitions
Administrator user.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Fix staff client Clear Expired Hold Shelf action

Accomodate an API change.  FIXME: See if can remove some of the redundant and/or
un-needed data being sent over the wire.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Only update MARC on full entry of fixed fields

AKA:
Lang is 3 characters long. Entering 1 character would cause focus to leave.
MARC would also update incorrectly.

This only triggers the update when the full 3 characters are entered.

This not only prevents issues with catalogers editing multi-character fixed
fields but also makes it less likely they accidentally corrupt the records.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamped upgrade script for schema.circ_holds_history_repairs

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Repair holds history func; sort circ history desc.

Update holds history to use oils_json_to_text instead of
oils_json_to_string, which does not exist.

Sort circ history newest to oldest by default.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamped upgrade script for more_cache_visbility_breakage

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Unwrapped upgrade script

for more_cache_visbility_breakage

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Extraneous semicolons break SQL

Remove them so that cache_copy_visibility can function.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fix overzealous template application

The idea was that we'd track templates if they were applied prior to copies
actually being specified in the unified interface, and then apply them "for
real" once copies were entered.  But these remembered templates kept applying
themselves whenever changes were made in the volume/copy creator portion of
the interface (possibly overriding tweaks made by staff).  So now we delete
the list of tracked templates once they're applied to actual copies.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

robustify (and klunkify) unified volume copy creator

Disable/style the Item Editor while changes in the volume/item pane are being
considered, and require an explicit press of a Ready Item Editor button to
enable the interface.  This reduces the chance of editing widgets in the item
editor from being ripped out from under you (for example, if you try to go
straight from editing a call number to editing an item attribute).

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

lp#792595: Don't allow pre-cats into record buckets via Item Status -> Actions for Catalogers

Alerts with the number of pre-cat records skipped prior to invoking the title bucket dialog.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

This adds a SAN box to the org unit editor's address editor pane.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Vandelay fix for merging without loading new

This fix is derivative of da3a453442050482a419deff91d3dc92fdbf132a
in master, but with new feature code removed for backport to 2.1
and 2.0.  It does the following:

- renames 'vlUploadQueueAutoImport' to 'vlUploadQueueImportNoMatch' to
  match identical change in master and to increase code clarity
- honors this flag when doing a merge.

Previously, if you checked one of the two auto-merge boxes, any records
which did not merge loaded as new records even if the 'Auto-Import
Non-Colliding Records' box was not checked.  You can now do one, the
other, or both together (auto-importing and merging) as needed.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Deleted a line the removed single quotes (') from search strings

The multiclass_query function replaces single quotes with spaces (') ( ).
This causes a problem when toggling between Advanced and Basic search.
If a search is conducted with a ' in it, that quote appears in the
basic search box displayed above the results.  However, if the user
then clicks the 'Advanced' button to toggle to the advanced search
the single quote is missing from the search term.  By removing the line
$query =~ /s/'/ /go; from Biblio.pm this problem is resolved.

Signed-off-by: Liam Whalen <lwhalen@evergreen-dev.catalogue.nrcan.gc.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Upgrade script for a patch from Steven Callender addressing payment types in money.materialized_summary_payment

Signed-off-by: Mike Rylander <mrylander@gmail.com>

A fix so that the last payment types will be cash_payment and check_payment rather than bnm_payment for cash and check payments.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Remove craftsman skin.

Signed-off-by: Joseph Lewis <joehms22@gmail.com>
Via LP:
https://bugs.launchpad.net/evergreen/+bug/820010

And this email thread:
http://libmail.georgialibraries.org/pipermail/open-ils-dev/2010-August/006269.html

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Format an unordered list appropriately

The list of developer prereqs was munged inline rather than as a list.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Provide Fedora-friendly instructions for the DBD libraries

We had only provided the Debian / Ubuntu location of the libdbi-libdbd
libraries, so add the Fedora location as well.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Bring more of the wiki docs over to the README

Document Perl prerequisites for a standalone PostgreSQL server.
Include a section on starting Evergreen and basic troubleshooting.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Update the README to include database installation instructions

A long time ago, the database server was installed by default.
Nowadays, installing the database server is a separate step
reserved for whatever machine you want to devote to PostgreSQL.
Not that you can't put it on the same machine as the rest of
Evergreen and OpenSRF...

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Correct varname for PostgreSQL RPMs

On Fedora, Red Hat, and CentOS, we were still trying to install
the set of PostgreSQL RPMs for PostgreSQL 8.4 using PGSQL_84_RPMS.
This had been updated to PGSQL_90_RPMS to match the updated
database version - using the right varname resolves the problem
(at least on Fedora).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Stamped upgrade script for user/miker/replace_field_fix

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Have replace_field return input XML when no replace rule is provided

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Avoid xml_transform retrieval in record attr def editor

config.xml_transform stores large chunks of XML.  Fetching it angers
Ejabberd on my test system.  All we need is the name, so use the new
AutoFieldWidget.searchOptions param to do just that.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

AutoFieldWidget support for augmenting pcrud search options

Adds a new searchOptions attribute to AutoFieldWidget for specifying
additional parameters to pcrud when retrieving linked objects.  The
initial use case is for supporting a "select" list to allow
AutoFieldWidget to retrieve only the display column of a linked object
and not the whole object.

Example:

 // fetch 'remote_field_name' on the remote objects instead of
 // fetching the entire object

 myGrid.overrideWidgetArgs.some_field = {searchOptions :
 {"select":{"some_hint":["remote_field_name"]}}};

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

calculate penalties when letting Mark Item Damaged add bills

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Fix oils_i18n_gettext id numbers

config.metabib_field ids 29/30 had 28 for translation id.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

use isNaN here, since NaN == NaN => false

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Correctly populate certain columns in the patron Messages interface

When applying penalties, the csp's referenced by the ausp's are fleshed.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Fix broken builds due to test that can't find its data

LP 817699 reports a problem that began with commit
e9cd992fa4dbf1013346336193cb7469ecee10a8, reintroducing a problem that
had previously been resolved with commit
f017d1261c369b9b5cc3c9cfc4f50d3cdf12a445. In short, tests can and are
run from different directories, but a new test opened a file without
making any allowance that the test might be run from anything other than
the /test/ directory.

This fix uses the dirname(__FILE__) approach to provide the appropriate
relative directory for the test data, and enables the tests to be
processed without dying.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Make users confirm they really want to delete lineitems from POs...

... when they've already been ordered. There's really no reason to ever
make such a deletion this that I can think of, but I use a confirm()
instead of stricter measures in case I'm missing something.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Stamped upgrade for user/dbs/oclcnumbers

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Prevent control numbers from duplicating

In maintain_control_numbers(), if you have more than one 001 or
003, and at least one is the correct one, you will end up
duplicating the correct number every time the record is saved.

For example, if the incoming record was record ID # 12345, and
the record contained:

001: 12345
001: ocm10202

... then after maintain_control_numbers() ran, the record would
contain:

001: 12345
001: 12345

Also, clean up some leftovers from the refactor I suggested in the
previous commit.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Add an unwrapped upgrade script for OCLC-aware control numbers

The upgrade script creates the SCN and LCCN search indexes and
populates them using metabib.full_rec as a source; cheating, but
the normalized values will work for non-exact search purposes. Sites can
reingest all of their bibs if they want exact search to work.

Also, refactor maintain_control_numbers() using a suggestion by
Dan Wells to eliminate some duplicate code.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>