working/Evergreen.git
13 years agoTpac: repaired propagator casulaty; using mkurl instead
Bill Erickson [Wed, 17 Aug 2011 21:37:13 +0000 (17:37 -0400)]
Tpac: repaired propagator casulaty; using mkurl instead

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTPAC: Strip the "page" GET param from author searches
Dan Scott [Wed, 17 Aug 2011 21:18:54 +0000 (17:18 -0400)]
TPAC: Strip the "page" GET param from author searches

mkurl() generates a URL that, by default, retains all of the parameters
that the currnt query string includes - useful for retaining library
search scope, etc. However, searches for authors that are launched by
clicking on the author's name in the search results page / record
details were failing in many cases because the "page" parameter came
along with it - and if there weren't five pages of results for page=5,
for example, then no hits would be shown.

This commit removes the page param from the URL. In other places, all of
the params are stripped (see cnbrowse) but as I assume we want to retain
search scope and potentially other parameters, we'll start with the
smallest possible change.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoMark a string for i18n support in the TPAC
Dan Scott [Wed, 17 Aug 2011 20:43:46 +0000 (16:43 -0400)]
Mark a string for i18n support in the TPAC

Even alt strings deserve translation support...

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoEscape TPAC "myopac" output to protect against XSS attacks
Dan Scott [Wed, 17 Aug 2011 19:36:15 +0000 (15:36 -0400)]
Escape TPAC "myopac" output to protect against XSS attacks

We're using the Template::Toolkit html and uri filters to ensure that
the usual suspects are escaped at output time to prevent trivial XSS
attacks.

berick: did some merge cleanup

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoAssume username, not barcode, in TPAC login
Dan Scott [Wed, 17 Aug 2011 17:01:08 +0000 (13:01 -0400)]
Assume username, not barcode, in TPAC login

In the absence of a barcode regex OU setting (opac.barcode_regex), the
TPAC was assuming that the entered value was a barcode. However, the
default JSPAC assumption was that the entered value was a username. This
commit makes the TPAC continue to function with the same assumptions as
the default JSPAC in the absence of a barcode regex OU setting.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoTPac: Removed errant 'html' almost-filter
Bill Erickson [Wed, 17 Aug 2011 20:55:43 +0000 (16:55 -0400)]
TPac: Removed errant 'html' almost-filter

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTpac: more html output sanitizing
Bill Erickson [Wed, 17 Aug 2011 20:50:50 +0000 (16:50 -0400)]
Tpac: more html output sanitizing

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTpac: more html output scrubbing
Bill Erickson [Wed, 17 Aug 2011 19:45:44 +0000 (15:45 -0400)]
Tpac: more html output scrubbing

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTPac: more aggressive dynamic output filtering
Bill Erickson [Wed, 17 Aug 2011 19:28:53 +0000 (15:28 -0400)]
TPac: more aggressive dynamic output filtering

Making heavier user of html/uri filters to prevent accidental or
malicious rendering of html from dynamic data.  More to follow.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTTPac: Hide pagination for 1-page hits
Bill Erickson [Tue, 16 Aug 2011 12:24:38 +0000 (08:24 -0400)]
TTPac: Hide pagination for 1-page hits

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTTpac: added simple/detailed record view option to results page
Bill Erickson [Mon, 15 Aug 2011 21:38:12 +0000 (17:38 -0400)]
TTpac: added simple/detailed record view option to results page

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTTPac: move results pageing chunk to new template
Bill Erickson [Mon, 15 Aug 2011 18:56:50 +0000 (14:56 -0400)]
TTPac: move results pageing chunk to new template

table.tt2 and paging are complex enough and will likely result in much
local customization.  Break them up into 2 page to simplify.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTTpac: show page range in results paging display
Bill Erickson [Mon, 15 Aug 2011 18:42:45 +0000 (14:42 -0400)]
TTpac: show page range in results paging display

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTTPac: change default any-format to 'All Formats'
Bill Erickson [Mon, 15 Aug 2011 15:28:19 +0000 (11:28 -0400)]
TTPac: change default any-format to 'All Formats'

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTTpac: option to override no-choice label in coded value selector
Bill Erickson [Mon, 15 Aug 2011 15:28:01 +0000 (11:28 -0400)]
TTpac: option to override no-choice label in coded value selector

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTTpac: Chilifresh reviews panel occupies the width of the table
Bill Erickson [Mon, 15 Aug 2011 15:18:33 +0000 (11:18 -0400)]
TTpac: Chilifresh reviews panel occupies the width of the table

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTTpac: minor i18n and other cleanup
Bill Erickson [Thu, 11 Aug 2011 21:21:03 +0000 (17:21 -0400)]
TTpac: minor i18n and other cleanup

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTTpac: removed last bits of propagator; minor cleanup
Bill Erickson [Thu, 11 Aug 2011 21:17:40 +0000 (17:17 -0400)]
TTpac: removed last bits of propagator; minor cleanup

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTTpac: Added Expand/Collaps all 'extras' tabs in detail page
Bill Erickson [Thu, 11 Aug 2011 20:59:22 +0000 (16:59 -0400)]
TTpac: Added Expand/Collaps all 'extras' tabs in detail page

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTTpac: more use of mkurl() and general cleanup
Bill Erickson [Thu, 11 Aug 2011 20:30:11 +0000 (16:30 -0400)]
TTpac: more use of mkurl() and general cleanup

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoForce-encode CGI param values to prevent decode errors
Bill Erickson [Thu, 11 Aug 2011 20:25:50 +0000 (16:25 -0400)]
Force-encode CGI param values to prevent decode errors

CGI.pm decode()'s parameter values, so if it encounters a value that
is already decoded, it will croak and kill the page.  Proactively encode
paramter values so decode() won't fail.

The better solution may be to determine how we get such data, but
until then, let's allow the t-pac to work on funky data.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTTpac: start using mkurl(); more todo..
Bill Erickson [Thu, 11 Aug 2011 15:56:41 +0000 (11:56 -0400)]
TTpac: start using mkurl();  more todo..

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTTopac: cgi-based replacement for url 'propagator'
Bill Erickson [Thu, 11 Aug 2011 15:56:15 +0000 (11:56 -0400)]
TTopac: cgi-based replacement for url 'propagator'

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTTpac: show MARC callnumber in record detail page
Bill Erickson [Wed, 10 Aug 2011 21:21:50 +0000 (17:21 -0400)]
TTpac: show MARC callnumber in record detail page

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTTpac: option to view larger sets of copies on record page
Bill Erickson [Wed, 10 Aug 2011 21:07:36 +0000 (17:07 -0400)]
TTpac: option to view larger sets of copies on record page

On record details page, added a "Show More Copies" option to show more
(50) copies per page of copies than the default (10).  Also added a
"Show Fewer Copies" option to return to the default copy page size.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTTpac: show full 245 for title on record details page
Bill Erickson [Wed, 10 Aug 2011 19:26:53 +0000 (15:26 -0400)]
TTpac: show full 245 for title on record details page

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTTpac: Capture and show all ISBNs on record details page
Bill Erickson [Wed, 10 Aug 2011 19:22:46 +0000 (15:22 -0400)]
TTpac: Capture and show all ISBNs on record details page

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoShow more subject data in the expanded ttopac subjects display
Bill Erickson [Wed, 10 Aug 2011 19:07:40 +0000 (15:07 -0400)]
Show more subject data in the expanded ttopac subjects display

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoAdded support for series display in ttopac record details
Bill Erickson [Wed, 10 Aug 2011 19:01:58 +0000 (15:01 -0400)]
Added support for series display in ttopac record details

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoAccommodate multiple 520a's in tt-opac summary display
Bill Erickson [Wed, 10 Aug 2011 18:16:13 +0000 (14:16 -0400)]
Accommodate multiple 520a's in tt-opac summary display

MARC args.summary is now an array of summary entries.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoMerge branch 'master' into template-toolkit-opac
Lebbeous Fogle-Weekley [Wed, 10 Aug 2011 14:36:27 +0000 (10:36 -0400)]
Merge branch 'master' into template-toolkit-opac

13 years agoGranular invalid data detection for Vandelay item import
Bill Erickson [Mon, 8 Aug 2011 19:05:47 +0000 (15:05 -0400)]
Granular invalid data detection for Vandelay item import

When an import item contains any data for a field, the code now verifies
the data is valid for the selected field.  When the data is not valid,
we capture information on which field is invalid and what data was used
for the field (import_error, error_detail) so it can be reported in the
interface.

This adds new import_errors:

import.item.invalid.status
import.item.invalid.price
import.item.invalid.deposit_amount
import.item.invalid.owning_lib
import.item.invalid.circ_lib
import.item.invalid.copy_number
import.item.invalid.circ_as_type

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agoShow copy status/location names in Vandelay items grid
Bill Erickson [Thu, 4 Aug 2011 22:14:00 +0000 (18:14 -0400)]
Show copy status/location names in Vandelay items grid

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agoStamping upgrade scripts for LP#818740
Thomas Berezansky [Tue, 9 Aug 2011 18:14:18 +0000 (14:14 -0400)]
Stamping upgrade scripts for LP#818740

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
13 years agoOrg setting for the result cap for Patron Search
Jason Etheridge [Sun, 31 Jul 2011 05:39:39 +0000 (01:39 -0400)]
Org setting for the result cap for Patron Search

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
13 years agoFix stop sign page race condition with checkout
Jason Etheridge [Mon, 8 Aug 2011 18:06:57 +0000 (14:06 -0400)]
Fix stop sign page race condition with checkout

This would happen most often when retrieving multiple patrons at the same time
from patron search--the stop sign page would show but then get trampled by the
checkout interface, which normally loads first.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
13 years agoTell OPAC to use checkin date, not stop_fines date
Thomas Berezansky [Mon, 25 Jul 2011 19:58:40 +0000 (15:58 -0400)]
Tell OPAC to use checkin date, not stop_fines date

The column is labeled "Date Returned", not "Date we stopped generating fines".

This does lead to "(fines accruing)" for an item that has hit max fines, or stopped fines for some other reason.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agousername login for web selfcheck
Jason Etheridge [Mon, 8 Aug 2011 19:22:34 +0000 (15:22 -0400)]
username login for web selfcheck

Changes the behavior for the patron-login component (after staff login) to match
the OPAC.  By default, it assumes you are logging in with a usrname, but if the
org unit setting 'opac.barcode_regex' is enabled and the incoming value matches,
then it gets treated as a library card barcode instead. If usrname is used, then
the card referenced by actor.usr.card is checked in lieu of a specified barcode.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoaction for marking items claimed never checked out
Jason Etheridge [Tue, 2 Aug 2011 03:07:24 +0000 (23:07 -0400)]
action for marking items claimed never checked out

Menu action in Patron Items Out for marking items as Claimed Never Checked Out.
Note that this action behaves differently than Claimed Returned, in that the
item is actually checked in and the transaction closed, and will not continue
to show up in Items Out for the patron.

If decide later to provide an option for making the two actions consistent,
there is code in the original working branch, collab/phasefx/claimed_never_cko,
which modifies the patron display and the .checked_out methods to look for
open CLAIMSNEVERCHECKEDOUT transactions.  Some cleanup would be needed to avoid
merge conflicts.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoStamped upgrade scripts for LP#797409
Mike Rylander [Tue, 9 Aug 2011 17:26:17 +0000 (13:26 -0400)]
Stamped upgrade scripts for LP#797409

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoIgn Reshelving->Available for status_changed_time
Jason Etheridge [Mon, 8 Aug 2011 13:07:40 +0000 (09:07 -0400)]
Ign Reshelving->Available for status_changed_time

This solves a complication when wanting to check status_changed_time against
offline xact_time when processing offline transactions.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoRobustify SKIP_ASSET_CHANGE functionality
Jason Etheridge [Thu, 4 Aug 2011 16:11:49 +0000 (12:11 -0400)]
Robustify SKIP_ASSET_CHANGE functionality

by skipping status_changed_time test if a barcode has been encountered in prior
offline transaction within a given session.  Also return the SKIP_ASSET_CHANGE
event for a given barcode if a prior test resulted in SKIP_ASSET_CHANGE

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoOffline checkin & renewal checks, & ou settings
Jason Etheridge [Thu, 4 Aug 2011 02:32:51 +0000 (22:32 -0400)]
Offline checkin & renewal checks, & ou settings

Augmented edoceo's patch for checking an offline checkout against an item's
Status Changed Time and throwing a SKIP_ASSET_CHANGED event if warranted as
follows:

1) include checkin and renewal transactions
2) add org unit settings for each, and a corresponding upgrade script
3) removed the description from the payload and created a dedicated ils_event

However, there are two issues affecting this functionality, even before my
meddling:

1) the Reshelving -> Available rollover updates an item's Status Changed Time,
   and can thus trigger this event
2) if an item is manipulated more than once in an offline session, then its
   Status Changed Time can be updated as the transactions are being processed,
   causing related transactions after the initial transaction to fail

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoLP#797409: Offline Transaction - Option to Skip Old Records
Atom Edoceo [Tue, 2 Aug 2011 05:54:37 +0000 (22:54 -0700)]
LP#797409: Offline Transaction - Option to Skip Old Records

Skip Copy with later Status Change Time on offline checkout import
Requires the following option in offline-config.pl
  $main::config{skip_late} = 1;

Signed-off-by: David Busby <code@edoceo.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoWhoops. Do that availability test regard of whether hold_boundaries are used.
Lebbeous Fogle-Weekley [Fri, 5 Aug 2011 20:01:09 +0000 (16:01 -0400)]
Whoops. Do that availability test regard of whether hold_boundaries are used.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoIn a middle-layer method for returning holdable formats on a metarecord,
Lebbeous Fogle-Weekley [Fri, 5 Aug 2011 18:31:03 +0000 (14:31 -0400)]
In a middle-layer method for returning holdable formats on a metarecord,

Do a better test of copy holdability than we were doing previously.
We can't do a perfect test: we don't really know what patron we're doing
this for, and even if we did, from here it's nontrivial to figure out
whether we're doing indb holds or script-based, much less run the tests.

Still, we can test whether a copy's in a holdable status, a holdable
location, and is itself not explicitly marked unholdable.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac
Bill Erickson [Fri, 5 Aug 2011 18:58:50 +0000 (14:58 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac

13 years agoMerge branch 'template-toolkit-opac' of git.evergreen-ils.org:evergreen/equinox into...
Bill Erickson [Fri, 5 Aug 2011 17:53:54 +0000 (13:53 -0400)]
Merge branch 'template-toolkit-opac' of git.evergreen-ils.org:evergreen/equinox into template-toolkit-opac

13 years agoSpeed up t-pac record details copy retrieval
Bill Erickson [Fri, 5 Aug 2011 17:52:17 +0000 (13:52 -0400)]
Speed up t-pac record details copy retrieval

Using JOIN filters instead of WHERE clauses, drastically speed up
paged/sorted copy retrieval, particularly for items with many copies, in
the record details page.

Thanks for the suggestions, Mike.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoThis doesn't need to be lying around any more
Lebbeous Fogle-Weekley [Fri, 5 Aug 2011 17:32:55 +0000 (13:32 -0400)]
This doesn't need to be lying around any more

Its purpose was superceded by another upgrade script in master.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agomrpeters caught this; wrong variable fed to error dialog
Jason Etheridge [Fri, 5 Aug 2011 02:27:45 +0000 (22:27 -0400)]
mrpeters caught this; wrong variable fed to error dialog

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoRepaired copy private/public note vandelay bug
Bill Erickson [Thu, 4 Aug 2011 20:46:54 +0000 (16:46 -0400)]
Repaired copy private/public note vandelay bug

Previously, all copy notes imported through vandelay were coming in as
public copy notes.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agoRevert "remove the unfinished id_as_barcode functionality"
Thomas Berezansky [Thu, 4 Aug 2011 19:25:08 +0000 (15:25 -0400)]
Revert "remove the unfinished id_as_barcode functionality"

This reverts commit 5fa01d69f7374c0c8710db4a951edb80ed5ae733.

Bit too soon, actually. Staff client still uses the function to
verify credentials.

Maybe I skipped this the first time on purpose.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
13 years agoremove the unfinished id_as_barcode functionality
Jason Etheridge [Sun, 31 Jul 2011 04:01:31 +0000 (00:01 -0400)]
remove the unfinished id_as_barcode functionality

remove the unfinished id_as_barcode setting for open-ils.actor and remove unused open-ils.actor.user.retrieve_id_by_barcode_or_username method

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
13 years agoStamped upgrade script for ACQ_INVOICE_REOPEN permission addition
Mike Rylander [Thu, 4 Aug 2011 19:10:36 +0000 (15:10 -0400)]
Stamped upgrade script for ACQ_INVOICE_REOPEN permission addition

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoUpgrade script for LP818311 branch.
Jason Stephenson [Thu, 4 Aug 2011 14:13:56 +0000 (10:13 -0400)]
Upgrade script for LP818311 branch.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoLP#818311: ACQ_INVOICE_REOPEN is missing
Michael Peters [Thu, 4 Aug 2011 12:59:15 +0000 (08:59 -0400)]
LP#818311:  ACQ_INVOICE_REOPEN is missing

This patch adds the missing ACQ_INVOICE_REOPEN to the Acquisitions
Administrator user.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoSpeed up holds history retrieval
Bill Erickson [Thu, 4 Aug 2011 19:01:09 +0000 (15:01 -0400)]
Speed up holds history retrieval

Consistent w/ circ history retrieval, use the longer column 'transform'
stored proc invocation to limit retrieval to historical holds IDs
instead of entire objects, which are later fetched/fleshed anyway.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoFix i18n build
Dan Scott [Fri, 29 Jul 2011 20:09:58 +0000 (16:09 -0400)]
Fix i18n build

Two problems thrown at the i18n build:

  * $$ quoting is not understood by db-seed-i18n.py; simple approach is
    to use standard single-quote escaping of the single-quote in
    950.data.seed-values.sql (warning: this might lead to other problems
    with the regular expression in db-seed-i18n.py)
  * authority.js includes Unicode values (shock!) and so we must treat
    the incoming strings as unicode() instead of plain old str()

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoFaster T-pac circ history retrieval
Bill Erickson [Thu, 4 Aug 2011 18:53:36 +0000 (14:53 -0400)]
Faster T-pac circ history retrieval

* Take advantage of the new default sorting behavior of
action.usr_visible_circs to perform limit/offset within the DB instead
of fetching the whole circ history in the mod_perl code and sorting
through it.

* Also use the  more powerful/verbose column transform syntax for
calling stored procedures to retrieve only the historical circ IDs
instead of the full circ objects, since we are re-fetching fleshed circ
objects later in the code.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoFix staff client Clear Expired Hold Shelf action
Jason Etheridge [Wed, 3 Aug 2011 04:44:41 +0000 (00:44 -0400)]
Fix staff client Clear Expired Hold Shelf action

Accomodate an API change.  FIXME: See if can remove some of the redundant and/or
un-needed data being sent over the wire.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoOnly update MARC on full entry of fixed fields
Thomas Berezansky [Thu, 28 Jul 2011 15:04:36 +0000 (11:04 -0400)]
Only update MARC on full entry of fixed fields

AKA:
Lang is 3 characters long. Entering 1 character would cause focus to leave.
MARC would also update incorrectly.

This only triggers the update when the full 3 characters are entered.

This not only prevents issues with catalogers editing multi-character fixed
fields but also makes it less likely they accidentally corrupt the records.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoStamped upgrade script for schema.circ_holds_history_repairs
Mike Rylander [Thu, 4 Aug 2011 18:36:17 +0000 (14:36 -0400)]
Stamped upgrade script for schema.circ_holds_history_repairs

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoRepair holds history func; sort circ history desc.
Bill Erickson [Thu, 4 Aug 2011 17:49:11 +0000 (13:49 -0400)]
Repair holds history func; sort circ history desc.

Update holds history to use oils_json_to_text instead of
oils_json_to_string, which does not exist.

Sort circ history newest to oldest by default.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoFix title/author sort. Use SVF 'titlesort'/'authorsort'
Bill Erickson [Thu, 4 Aug 2011 15:47:47 +0000 (11:47 -0400)]
Fix title/author sort.  Use SVF 'titlesort'/'authorsort'

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoRepaired qtype bug introduced w/ bool searching
Bill Erickson [Thu, 4 Aug 2011 12:56:46 +0000 (08:56 -0400)]
Repaired qtype bug introduced w/ bool searching

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen into QP_bucket_filter
Lebbeous Fogle-Weekley [Wed, 3 Aug 2011 20:42:34 +0000 (16:42 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen into QP_bucket_filter

13 years agoCast needed
Lebbeous Fogle-Weekley [Wed, 3 Aug 2011 20:42:17 +0000 (16:42 -0400)]
Cast needed

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agoSpeed up hold editing by only fetching hold to edit
Bill Erickson [Wed, 3 Aug 2011 20:04:26 +0000 (16:04 -0400)]
Speed up hold editing by only fetching hold to edit

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoRepaired bug in t-pac org selector value propagation
Bill Erickson [Wed, 3 Aug 2011 19:33:24 +0000 (15:33 -0400)]
Repaired bug in t-pac org selector value propagation

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoStamped upgrade script for more_cache_visbility_breakage
Mike Rylander [Wed, 3 Aug 2011 17:46:24 +0000 (13:46 -0400)]
Stamped upgrade script for more_cache_visbility_breakage

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoUnwrapped upgrade script
Thomas Berezansky [Mon, 25 Jul 2011 20:39:57 +0000 (16:39 -0400)]
Unwrapped upgrade script

for more_cache_visbility_breakage

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoExtraneous semicolons break SQL
Thomas Berezansky [Mon, 25 Jul 2011 20:39:07 +0000 (16:39 -0400)]
Extraneous semicolons break SQL

Remove them so that cache_copy_visibility can function.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoFix overzealous template application
Jason Etheridge [Mon, 1 Aug 2011 06:10:15 +0000 (02:10 -0400)]
Fix overzealous template application

The idea was that we'd track templates if they were applied prior to copies
actually being specified in the unified interface, and then apply them "for
real" once copies were entered.  But these remembered templates kept applying
themselves whenever changes were made in the volume/copy creator portion of
the interface (possibly overriding tweaks made by staff).  So now we delete
the list of tracked templates once they're applied to actual copies.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agorobustify (and klunkify) unified volume copy creator
Jason Etheridge [Mon, 1 Aug 2011 05:40:22 +0000 (01:40 -0400)]
robustify (and klunkify) unified volume copy creator

Disable/style the Item Editor while changes in the volume/item pane are being
considered, and require an explicit press of a Ready Item Editor button to
enable the interface.  This reduces the chance of editing widgets in the item
editor from being ripped out from under you (for example, if you try to go
straight from editing a call number to editing an item attribute).

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agolp#792595: Don't allow pre-cats into record buckets via Item Status -> Actions for...
Jason Etheridge [Thu, 21 Jul 2011 19:25:28 +0000 (15:25 -0400)]
lp#792595: Don't allow pre-cats into record buckets via Item Status -> Actions for Catalogers

Alerts with the number of pre-cat records skipped prior to invoking the title bucket dialog.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoThis adds a SAN box to the org unit editor's address editor pane.
James Fournie [Thu, 28 Jul 2011 19:08:18 +0000 (12:08 -0700)]
This adds a SAN box to the org unit editor's address editor pane.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoUpgrade script for a patch from Steven Callender addressing payment types in money...
Mike Rylander [Wed, 3 Aug 2011 17:02:30 +0000 (13:02 -0400)]
Upgrade script for a patch from Steven Callender addressing payment types in money.materialized_summary_payment

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoDeleted a line the removed single quotes (') from search strings
Liam Whalen [Wed, 20 Jul 2011 16:49:27 +0000 (12:49 -0400)]
Deleted a line the removed single quotes (') from search strings

The multiclass_query function replaces single quotes with spaces (') ( ).
This causes a problem when toggling between Advanced and Basic search.
If a search is conducted with a ' in it, that quote appears in the
basic search box displayed above the results.  However, if the user
then clicks the 'Advanced' button to toggle to the advanced search
the single quote is missing from the search term.  By removing the line
$query =~ /s/'/ /go; from Biblio.pm this problem is resolved.

Signed-off-by: Liam Whalen <lwhalen@evergreen-dev.catalogue.nrcan.gc.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years ago2.0-2.1 upgrade integration of a patch from Steven Callender addressing payment types...
Mike Rylander [Wed, 3 Aug 2011 16:40:42 +0000 (12:40 -0400)]
2.0-2.1 upgrade integration of a patch from Steven Callender addressing payment types in money.materialized_summary_payment

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoUpgrade script for a patch from Steven Callender addressing payment types in money...
Mike Rylander [Wed, 3 Aug 2011 16:38:24 +0000 (12:38 -0400)]
Upgrade script for a patch from Steven Callender addressing payment types in money.materialized_summary_payment

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoA fix so that the last payment types will be cash_payment and check_payment rather...
Steven Callender [Thu, 28 Jul 2011 19:37:27 +0000 (19:37 +0000)]
A fix so that the last payment types will be cash_payment and check_payment rather than bnm_payment for cash and check payments.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoQuote container id param for safety
Mike Rylander [Wed, 3 Aug 2011 00:05:53 +0000 (20:05 -0400)]
Quote container id param for safety

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoMerge branch 'QP_bucket_filter' of git.evergreen-ils.org:evergreen/equinox into QP_bu...
Mike Rylander [Wed, 3 Aug 2011 00:02:28 +0000 (20:02 -0400)]
Merge branch 'QP_bucket_filter' of git.evergreen-ils.org:evergreen/equinox into QP_bucket_filter

13 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into QP_bucket_filter
Mike Rylander [Wed, 3 Aug 2011 00:01:49 +0000 (20:01 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into QP_bucket_filter

13 years agoFixed some syntax errors, but getting no results when I'd expect some
Lebbeous Fogle-Weekley [Tue, 2 Aug 2011 21:34:10 +0000 (17:34 -0400)]
Fixed some syntax errors, but getting no results when I'd expect some

I searched with this

    container(bre,bookbag,12,$authtoken)

where $authtoken is substituted with an actual live authtoken for the
user that owns that container, and here is the example generated query
that returns no results:

  SELECT * FROM  search.query_parser_fts(
            4::INT,
            2::INT,
            $core_query_3553$SELECT  m.source AS id,
ARRAY_ACCUM(DISTINCT m.source) AS records,
1.0/((AVG(
        (1)
) * COALESCE( NULLIF( FIRST(mrd.attrs @> hstore('item_lang', $_3553$eng$_3553$)), FALSE )::INT * 5, 1)))::NUMERIC AS rel,
1.0/((AVG(
        (1)
) * COALESCE( NULLIF( FIRST(mrd.attrs @> hstore('item_lang', $_3553$eng$_3553$)), FALSE )::INT * 5, 1)))::NUMERIC AS rank,
FIRST(mrd.attrs->'date1') AS tie_break
FROM  metabib.metarecord_source_map m
JOIN metabib.record_attr mrd ON (m.source = mrd.id)

JOIN ( SELECT ci.target_biblio_record_entry AS container_item
        FROM  container.biblio_record_entry_bucket_item ci
              JOIN container.biblio_record_entry_bucket c ON (c.id = ci.bucket)

        WHERE c.btype = $_3553$bookbag$_3553$ AND c.id = 12
              AND (c.pub IS TRUE OR c.owner = 1)) container ON (container.container_item = mrd.id)

WHERE 1=1

AND (TRUE)
GROUP BY 1
ORDER BY 4 ASC NULLS LAST, 5 DESC NULLS LAST, 3 DESC
LIMIT 10000
$core_query_3553$::TEXT,
            $${}$$::INT[],
            $${}$$::INT[],
            NULL::INT,
            1000::INT,
            10000::INT,
            'f'::BOOL,
            't'::BOOL
        );

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agoRemove craftsman skin.
Joseph Lewis [Tue, 2 Aug 2011 20:41:37 +0000 (14:41 -0600)]
Remove craftsman skin.

Signed-off-by: Joseph Lewis <joehms22@gmail.com>
Via LP:
https://bugs.launchpad.net/evergreen/+bug/820010

And this email thread:
http://libmail.georgialibraries.org/pipermail/open-ils-dev/2010-August/006269.html

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
13 years agoMerge branch 'QP_bucket_filter' of git.evergreen-ils.org:evergreen/equinox into QP_bu...
Mike Rylander [Tue, 2 Aug 2011 19:01:55 +0000 (15:01 -0400)]
Merge branch 'QP_bucket_filter' of git.evergreen-ils.org:evergreen/equinox into QP_bucket_filter

13 years agoActually JOIN the VALUES list; syntax copy/paste-o; use the correct field for bre...
Mike Rylander [Tue, 2 Aug 2011 18:58:57 +0000 (14:58 -0400)]
Actually JOIN the VALUES list; syntax copy/paste-o; use the correct field for bre containers

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoAdd cointainer() and record_list() filters to QueryParser
Mike Rylander [Fri, 22 Jul 2011 19:10:23 +0000 (15:10 -0400)]
Add cointainer() and record_list() filters to QueryParser

The container() filter takes 3 or 4 positional params:
  - class (bre, acn, acp, au)
  - type  (bookbag, etc -- btype of the container)
  - id    (container id)
  - token (authtoken, optional, for checkin ownership of non-public containers)

The record_list() filter takes a list of record ids to restrict the search by.
These are bib ids by default, but are treated as metarecord ids in the presence
of the #metabib (aka #metarecord) modifier.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoActually JOIN the VALUES list; syntax copy/paste-o; use the correct field for bre...
Mike Rylander [Tue, 2 Aug 2011 18:58:57 +0000 (14:58 -0400)]
Actually JOIN the VALUES list; syntax copy/paste-o; use the correct field for bre containers

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoMerge branch 'template-toolkit-opac' of git.evergreen-ils.org:evergreen/equinox into...
Mike Rylander [Tue, 2 Aug 2011 18:39:35 +0000 (14:39 -0400)]
Merge branch 'template-toolkit-opac' of git.evergreen-ils.org:evergreen/equinox into template-toolkit-opac

13 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac
Mike Rylander [Tue, 2 Aug 2011 18:39:31 +0000 (14:39 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac

13 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into QP_bucket_filter
Mike Rylander [Tue, 2 Aug 2011 18:39:18 +0000 (14:39 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into QP_bucket_filter

13 years agoRepaired seed data T-pac merge conflict
Bill Erickson [Tue, 2 Aug 2011 17:04:25 +0000 (13:04 -0400)]
Repaired seed data T-pac merge conflict

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agolp758945: make receipt template macros repeatable
Galen Charlton [Tue, 2 Aug 2011 16:20:32 +0000 (12:20 -0400)]
lp758945: make receipt template macros repeatable

Patch from Jason Boyer to allow macros to be used
more than once in a section; prior to this patch, only
the first occurrence was replaced with the substitation
value.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
13 years agoMerge branch 'master' of git://git.evergreen-ils.org/Evergreen
Thomas Berezansky [Tue, 2 Aug 2011 16:09:33 +0000 (12:09 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

13 years agoFormat an unordered list appropriately
Dan Scott [Sun, 24 Jul 2011 19:51:38 +0000 (15:51 -0400)]
Format an unordered list appropriately

The list of developer prereqs was munged inline rather than as a list.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
13 years agoProvide Fedora-friendly instructions for the DBD libraries
Dan Scott [Thu, 21 Jul 2011 22:39:06 +0000 (18:39 -0400)]
Provide Fedora-friendly instructions for the DBD libraries

We had only provided the Debian / Ubuntu location of the libdbi-libdbd
libraries, so add the Fedora location as well.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
13 years agoBring more of the wiki docs over to the README
Dan Scott [Thu, 21 Jul 2011 22:35:17 +0000 (18:35 -0400)]
Bring more of the wiki docs over to the README

Document Perl prerequisites for a standalone PostgreSQL server.
Include a section on starting Evergreen and basic troubleshooting.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>