LP#1787479: Use help tips for settings descriptions

We are now using popup help tips for descriptions on this page. Adding these
help tips for the new settings added through this branch.

Also changes strings in this interface to translatable text.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1787479: Restore spacing fixes

Restore spacing fixes introduced by Garry Collum that were overwritten with
the original branch.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Modified Evergreen custom print label toolbox with save modifications.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1787479: Custom label printing toolbox

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/staff/cat/printlabels/t_view.tt2

LP1806087 Repair SQL upgrade script file name

Make the name of the file match the upgrade version number applied by
the file.

As is, build/tools/update_db.sh fails to recognize a new update is
available.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1784893 Reporter - External Documentation Links

Removed old xulG logic which was not working in
the web client. Link now opens in new browser tab.

Signed-off-by: McCanna <tmccanna@georgialibraries.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1797934: Simplify header labels

Since the patron is already on the "Reservations" tab in their account,
it seems unnecessary to use the word "Reservations" in the header
labels. Also, simpler labels will make translations easier, since "Start
time" and "End time" are already used in other Bookings interfaces.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1797934: Add a patron's booking reservations to their OPAC account

This commit creates a new tab in the patron OPAC account area where a
patron can view their current bookings.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1806087 Stamp upgrade script for staff catalog preview

Signed-off-by: Dan Wells <dbw2@calvin.edu>

lp1806087 Place Holds Improvements

- Disable SMS Carriers dropdown if Notify by SMS  unchecked.
- Move Search for patron button to same level as "Place Hold (name)" text.
- Add Search icon to "Search for Patron" button
- Add "Submit" button to Barcode input for improved UX.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/catalog/hold/hold.component.html

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1806087 Angular catalog Ang7 & lint repairs

Update rxjs imports to work with Angular7.  Add ng-lint repairs.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1806087 Experimental Angular catalog release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1806087 Org setting to enable experimental staff catalog

Adds a new org unit setting "GUI: Enable Experimental Angular Staff
Catalog" (ui.staff.angular_catalog.enabled).  When set to true, a new
navbar menu item will appear in both the Angular and AngJS client menus
for "Staff Catalog (Experimental)".  This action directs the user to the
Angular staff catalog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1806087 Angular staff catalog phase II.

* Record detail tabs redirect to AngJS catalog where needed.
* Initial holds placement UI.
* Record baskets, actions, and UI.
* Ported MonographParts tab to Angular
* Set default catalog tab
* Browse
* MARC search
* Identifier search
* pub date filter
* Record detail 'View in Catalog' button
* Group formats and editions

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Lp 1813172: Option to Specify Attributes for Reingest in pingest.pl

Add the --attr option to pingest.pl to specify one or more specific
attributes to be reingested by metabib.reingest_record_attributes.

Add a release note.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

lp1717551 Holdings view action menu clarity adjustment

- Added clarifying wording for add, edit, and delete options

Signed-off-by: Katlyn Beck <kbeck@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/cat/catalog/t_holdings.tt2

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1813647 Titles for Angular admin and splash page

Add page titles for auto-generated admin pages, workstation admin, and
the root splash page.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1813647 Angular page title component & sandbox example

Adds a new component <eg-title /> which may be used to pass strings to
the native Angular Title service.

Each title may have a prefix and/or a suffix.  If both are defined, they
are separated by a "-" (by default / en-US) and the prefix is tructed to
12 characters, consistent with AngularJS strings.setPageTitle()
function.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1779158 Stamping upgrade scripts for Angular Vandelay

Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1779158 Angular7 and ng-lint updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1779158 Import field id/class mismatch fix

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1779158 Always clear import selection

Clear the import selection (e.g. Queue => Import All Items) from the
import UI when the user navigates away, regardless of whether the import
succeeded.  Otherwise, the import UI gets stuck in selection mode
requiring the user to manually clear it.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1779158 Vandelay workstation setting repairs/additions

* Fix some workstation setting names that were missing the 'eg.grid.*'
  prefix
* Add workstation setting types for merge profile and attr definition
  admin pages.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1779158 Import non-matching saved template repair

Fix issue in Vandelay import form templates where template variable name
did not match the form variable name.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1779158 Cache new queues / display active queues

* Only list active (non-complete) queues in the Vandelay queue selector
  combobox.
* Display an alert message when the user attempts to create a queue
  whose name collides with an existing queue for the user.
* Be sure newly created queues are added to the local cache of queues in
  the Vandelay service.
* Remove unused activeQueue list from vandelay.service to avoid having
  to maintain 2 separate queue caches.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1779158 Angular alert dialog component

Similar to the PromptDialogComponent except it displays a simple message
(formatted as 'danger') and the only option available to the user is to
close the dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

lp1779158 Inspect Queue Improvements

- Add "Delete selected" option to Authority Queues
- Change Queuetype to 'authority' from 'auth' when selecting single record to view
in auth record queue.
- Ensure "Imported As" link correctly navigates to Auth record view for Auth Queues

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue-list.component.html
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue.component.html
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue.component.ts

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

lp1779158 Vandelay Authority Import Tweaks

- Check for "Auth" string
- Dummy rec.import_items when record is not bib
- Teach resolveQueue() to assume startQueueId unless a queue is selected already

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/import.component.ts
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue.component.ts
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/vandelay.service.ts

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1779158 Vandelay UI accessibilty/usability improvements

* Associate <input>'s with their labels in the import and export forms
* Hide the MARC removal groups selector when record type is authority.
* Disable ACQ copy overlay option when record type is authority.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1800481 Vandelay import form templates

Support saving MARC Import form values as named templates.  Values are
stored as (by defualt) workstation settings.  A template may be selected
as the default and templates may be deleted.

Includes release notes update angular vandelay.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1779158 Ang6 Vandelay Release Notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1779158 Ang6 Vandelay UI Port

Port of the MARC Import/Export UI from a Dojo-driven interface to a
Angular(6) interface.

Includes an additional UI called "Recent Imports" which displays
Vandelay session tracker information for both active sessions and those
within the selected time frame.  Active sessions are updated regularly
to display progress to the user.

Includes grid persist key workstation settings.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Lp 1808580: Remove Installation Support for Ubuntu 14.04

Remove prerequisite installation on Ubuntu 14.04 "Trusty Tahr" from
Makefile.install and the edi_translator installation script.

Remove and/or update references to Ubuntu 14.04 Trusty Tahr to Ubuntu
18.04 Bionic Beaver in the server installation and upgrade documents.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1802594: (follow-up) avoid a regression on "Copy" => "Item"

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1802594 - Splash Page Image Alt Text

Added alt="evergreen" to the logo image on the splash page, and alt=""
role="presentation" to the icon images. This was done for both the AngJS
and Ang7 clients.

Signed-off-by: Sam Link <slink@LIBPC002>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Lp 1813290: Fix IAMBROWSER check in ac lineitem table.

Looks like commit e9a9875d added a check for IAMBROWSER that missed
the window.  This commit adds the window.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1796225: Only auto-focus search on the home page

For a11y and usability, it's better to autofocus form fields
only when they are the main purpose of a page.

To test:
1) In the public catalog, visit the search results, record view,
library details, basket, and password reset pages.  Notice that
the cursor leaps to the search bar in each of these pages.
2) Apply this commit.
3) Re-visit all those pages.  Notice that the cursor no longer
leaps to the search bar.
4) Visit the home page of the public catalog.  Notice that the
cursor still leaps to the search bar on this page only.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1799963: Adjust fix to Staff Default Adv Search

By moving the only assignment to $scope.catalog_url inside
an if(<url is advanced search>) then only the advanced search
page can load in the opac. By adding a second assignment
inside an else block all opac pages can load again.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1799963 - fix catalog advanced search type default

Since eg.search.adv_pane is now a server stored WS setting
it needed to be fetched with the proper way in order to work.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1806709: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Lp 1806709: Add circ.patron.billhistory_xacts persist key to database.

We add the eg.grid.circ.patron.billhistory_xacts persist key to
config.workstation_setting_type in the database.

This is a follow-on to the LP1739606: Allow saving Billing History
xacts grid commit and should be applied to master and rel_3_2.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1726568: expose circ lib and owning lib fields to spine/pocket labels

This patch fleshes the item circulation library and owning library
fields so that spine/pocket labels can include the short name or
full name of the OU rather than just the ID.  As a consequence, the
following fields are now available for label templates:

* copy['call_number.owning_lib.id']
* copy['call_number.owning_lib.shortname']
* copy['call_number.owning_lib.name']
* copy['circ_lib.id']
* copy['circ_lib.shortname']
* copy['circ_lib.name']

If, for some reason, existing label templates intentionally use
copy['call_number.owning_lib'] or copy['circ_lib'] to include the numeric
ID of the OU on the label, they will need to be replaced with
copy['call_number.owning_lib.id'] or copy['circ_lib.id'] respectively.

To test
-------
[1] Apply the patch.
[2] Open the print labels window for an item and try including one
    or more of the new fields listed above; verify that the current
    value is displayed on the label preview.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1752665: suppress located URIs in holdings view

To test:

[1] Locate or create a bibliographic record that has at least
    one located URI (e.g., an 856 with a $9 containing an org
    unit code)
[2] View the record in the Holdings View in the web staff interface,
    with the 'Show empty call numbers' (or volumes) option
    selected.
[3] Note that rows are displayed with a call number label of '##URI##';
    these are for the located URIs and should not be visible here.
[4] Apply the patch and repeat step 2. This time the '##URI##' entries
    should not display.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1812733: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1812733: put in correct version of actor.usr_delete()

This fixes an issue in the previous patch where second_given_name
would never have been NULLed.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1812733 - Repair actor.usr_delete function.

The Parent/Guardian feature altered the actor.usr_delete
function, but accidentally tries to update the "guardian"
field twice.  This fixes that problem.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Stamping upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP1811156 Angular server admin grid settings

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP1811156 Activate Angular server admin page

Point Admin -> Server Admin from AngJS and Angular navbars to the
Angular version of the server admin splash page.

Includes Angular auto-admin page sanity check for cases where a route
has no extra data.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1715767 - stamping upgrade scripts

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1715767: remove privacy waiver entries when purging user data

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1715767: remove privacy waiver entries when referenced actor.usr rows are deleted

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1715767: Allow others to use my account (privacy waiver)

Use case: Jane Doe has a hold ready for pickup but is unable to come
into the library.  Her husband John Doe goes to the library to pick up
the hold on her behalf.  His name is listed on Jane's account, so
library staff know it's okay to check out the book on Jane's account and
give it to John.

This commit adds a new table which lists the names of people who are
allowed to place holds, pick up holds, check out items, or view
borrowing history for a user account.  Staff can add, edit, or remove
entries via the patron editor in the web client; patrons can do so in My
Account.  The entries are not linked to other user accounts and they do
not add any extra functionality.  They are essentially special patron
notes for circulation staff.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Lp 1805897: Add Release Note

Signed-off-by: Jason Stephenson <jason@sigio.com>

Lp 1805897: Add Item Status to the Holdings of marc_export.in

Export status in the 852 subfield s when exporting items.

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: John Yorio <jyorio@equinoxinitiative.org>
Signed-off-by: Steve Callender <stevecallender@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1801984 Upgrading Angular 6 to Angular 7

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1783421 - Make Copy Alerts permission not global

For some reason copy alerts require global permissions.  Instead
update the IDL for asset.active_copy_alert and asset.copy_alert to
require {CREATE,VIEW,UPDATE,DELETE}_COPY_ALERT perms only as far as
they are scoped for the circ lib of the copy.

Signed-off-by: James Fournie <jfournie@vcc.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1809288 Angular Booking Admin release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1809288 Stamping SQL upgrade for booking admin

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1809288: Fix a small javascript error when value is undefined

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1809288 Avoid booking grid prefix doubling

Teach the booking admin to avoid doubling up the grid prefix, which
would lead to grid settings with names like eg.grid.booking.booking.*

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1809288 Angular fm-editor read-only additions

* Add read-only view to org-select
* FM editor displays read-only values as plain text
* Mark readOnly checkboxes "disabled"
* Link fields only fetch linked data when an IDL selector exists
* Minor code/style changes
** Define all class vars before class methods (ng-lint)
** Replace some tabs with spaces (ng-lint)
** Avoid unnecessary type defs with default values (ng-lint)
** More const goodness (ng-lint)
** camelCase some vars for consistentcy

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1809288: Make some brt fields read-only

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1809288: Add workstation grid settings for booking admin

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1809288: Port Booking Admin to Angular

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1808268 eg2 grid action disableOnRows sanity check

The === null test for determining if a disableOnRows handler was set was
not broad enough to capture undefined values.  This commit changes it to
a more generic if() test to cover null/undefined.  Also, instead of
creating a dummy function in the action, the testing code checks for the
presence of the function at run time.

Apply a fix to an ng-lint warning introduced by this series of commits in
the sandbox code.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1808268 eg2 grid rename action disable option

Rename the "disabled" attribute on toolbar-action to "disabeOnRows" to
better clarify the expected input value: function returning bool instead
of bool variable.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1808268: Add [disable] option to <eg-grid-toolbar-action> in eg2

To test:
1) Apply this commit and recompile eg2.
2) Open the eg2 sandbox (https://yourdomain/eg2/staff/sandbox)
3) Ensure that the action called "Action that needs a single row"
is only enabled when one row of the grid is selected.
4) Create more <eg-grid-toolbar-actions> on grids in eg2.  Make sure
that they all enable/disable those actions per the output of the
functions you reference in the [disabled] attribute.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

Forward-port 3.2.3 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Forward-port 3.1.9 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1727345 - fix bibsource when importing or overlaying

This addresses several issues that were causing the
bib source to either not display correctly on the record page
or not save correctly when editing z3950 imports/overlays
Refactors passing around of bib source into eg-marc-edit and it's
child directive egMarcEditBibsource.

Two paths to test:
Path A)
    1. Import a new bib record from z3950, but via "Edit then Import"
    2. Bring up marc editor and choose save w/ bib source.
    3. Verify chosen bib source saved correctly on record page.
Path B)
    1. Mark a record as target for Overlay, go to z3950 import.
    2. Make a search, select item for Overlay.
    3. Choose Edit z3950 record to bring up marceditor, save with a bib source.
    4. Verify chosen bib source saved correctly on record page.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1812698 - stamping upgrade script

Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1812698 - Fix broken pubdate display

reporter.simple_record, which is now used more
extensively for bib display, had a copy-paste error
originating in 2014 that now gets corrected.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP1807764 Angular grid gets datePlusTime option

Adds a new boolean datePlusTime option to the Angular grid column
configuration, informing the grid to display both date and time in the
cell for a datetype=timestamp column.

Includes sandbox example.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding one more note to 3.2.3 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1805856: Open new windows for record operations

This branch changes the call from $window.location.open
to match other others ($window.open). Testing the 2 z39.50
changes worked as expected!

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1805856: Open records in new tabs

Catalogers have given the feedback that it's very helpful to have
certain records open in a new tab after they perform certain tasks.

This commit opens the relevant records in a new tab in the following
circumstances:
1) Cataloging > Z39.50 > Import > Go to record (previously opened in the
existing tab)
2) Cataloging > Z39.50 > Overlay > Overlay (previously did not open the
overlaid record at all)
3) Cataloging > Record Buckets > Merge (previously opened the lead
record in the existing tab)

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Boyer <JBoyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: adding release notes for 3.2.3

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding 3.1.9 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1742521: Receipt Count Repair

The div wrapping the receipt printing controls was
shown or hidden using an ng-if declaration which
created a new $scope as explained in bug 1696238,
which caused the controller to not notice that the
value was changed. Changing that to an ng-show
allows the updated value to get where it needs to
be.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP1804716: grab recall-able copies before they are filtered out

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

Lp 1803734: Only push on-order purchase orders in edi_order_pusher.pl.

Add a check for the state of purchase orders being on-order when
gathering them in edi_order_pusher.pl.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Lp 1801998: Deprecate Hatch Storage Grammar Fix

Make a minor fix to punctuation in a newly added message.

Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1801998 Deprecate Hatch for data storage

Add a deprecation warning to the Hatch configuration page notifying
users that Hatch for storage is deprecated.  Includes suggestions on how
to migrate away from Hatch for storage.

Remove the unusued "Use Hatch for Offline Files" option.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1737800 - add delete action to pending patrons

This adds a way to remove a pending/staged user from
the pending users grid.

Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1810802 org_top() SQL upgrade repairs

1. Drop the org_top function before recreating it since the return type
changes.

2. Fis syntax error in "COMMIT:"

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1765179 - fix issue with pending/staged user reg

After completing a staged user registration, the controller
in regctl.js was refreshing to the same route, and
trying to fetch the same staged user, but never finding it
as it was no longer staged/pending. This addresses that bug
and adds a bChannel refresh to the pending grid, so once
the user is registered in the child tab, it closes the tab and
the pending user grid is updated.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>

docs: LP1258628: screenshots & updates to actiontriggers.adoc

Added a handful of screenshots; added language for Message Center definitions, and pulled in language about testing action triggers from this document: http://docs.evergreen-ils.org/dev/_creating_action_triggers.html

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1782652: Make template dropdown larger in Volume/Copy Editor

To test:
1) Open an item in the volume/copy editor.
2) Go to the Copy Templates tab. Note the spacing of the template bar.
3) Create a few templates.  Give them names of 30 characters or more.
4) Go back to the Edit tab and select one of your new templates.  Note
that after you have selected it, the name of your template does not fit
in the dropdown box, and is cut off at the end.
5) Apply this commit.
6) Go to the Copy Templates tab again.  Note that the spacing of the
template bar has not changed.
7) Go to the Edit tab.  Note that the template dropdown has changed
to be much larger.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Janet Schrader <jschrader@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1806968 Stamping SQL upgrade: Vand. session tracker fixes

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1806968 Teach Vandelay to pass correct auth tracker type

Pass the correct value ('authority') when creating a Vandelay session
tracker entry for authority records.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>

LP#1806968 Vand ses. tracker upgrade SQL additions

Force the default value to show in the DB as 'bib'::text instead of
'bib'::vandelay.bib_queue_queue_type, which might be confusing.

Removed some stray SQL from the script.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>

LP#1806968 Vandelay record_type sql fix

- Change record_type to TEXT rather than an enum, constrained
with the option of "authority" or "bib"

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/sql/Pg/012.schema.vandelay.sql
new file:   Open-ILS/src/sql/Pg/upgrade/XXXX.schema.vandelay-record-type-fix.sql

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>

LP1807523: Adding some randomness to DOM ID generation

Ensures ID values across multiple FmEditor instances in a page will not
collide.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1807523: Associating labels and inputs in angular fmeditor

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

Translation updates - newpot

Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1730726: Stamping upgrade script

Signed-off-by: Ben Shum <ben@evergreener.net>

LP 1730726: Add Release Notes for PostgreSQL 10 Support.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

Lp 1730726: Fix lp1501781-unaccent_and_squash.pg for PostgreSQL 9.6

PostgreSQL 9.6 apparently exhibits the same behavior as Postgresql 10
when it comes the OE ligature in the unaccent function.  We modify the
test case to take that into account.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

Lp 1730726: Fix lp1501781-unaccent_and_squash.pg for PostgreSQL 10

PostgreSQL 10 has improvements in the unaccent function used by the
evergreen.unaccent_and_squash function.  The test needs a small
modification to take this into account.  Actual code change from Mike
Rylander with a little typo fix.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>