LP#1772680: Fixed download issue

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Implementation of Checkout, Hold, and other enhancements

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: enhancements to RBDigital integration

This feature allows searching of RBdigital resources from the Evergreen
catalog without needing to import and maintain bibliographic records for
the RBdigital resources.

The RBdigital search results will appear in the OPAC on a different tab -
a search in basic or advanced Evergreen search will carry over to the
RBdigital tab (along with filters when mapping is feasible) so that the
user can type in a search once and see both sets of results. The design
of the RBdigital tab will make use of the OPAC styling for consistency.

This feature is sponsored by Recorded Books (RBDigital) and
GPLS and was primary written by Jaswinder Singh with code contributions
and testing from the Equinox Open Library Initiative.

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Remove "In Receiving" status from magical status list

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Adding 'In Receiving' status to back-end functionality.

KPAC Updates: Add E-Read Kids

Add new permanent KPAC icon for E-Read Kids, hide summer reading,
show back to school.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Customization: Alter wording for COPY_CIRC_NOT_ALLOWED

Change wording of COPY_CIRC_NOT_ALLOWED message because the default
wording indicates that it is a problem with the copy, but it can
also be triggered when there is a problem with the user (such as when
a Digital Only user attempts to check out a physical item).

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1713138 EDI buyer codes from RFF+API

Support extracting buyer code (AKE edi_account.vendcode) values directly
from the EDI RFF+API field.  This provides better matching to
edi_accounts based on vendcode values for inbound EDI messages.

The code will still fall back to extracting vendcodes appended to the SAN,
when no RFF+API is present.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Modifies our previously customized code for the new books dropdown
list so that it limits what is retrieved in the new books supercat
feeds by available statuses only.

LP #1705497 Replaces functionality in web client from legacy
XUL client by including a find function for originating
acquisition where it exists.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1642036 Group member detail grid query repair

Teach the grid to automatically use the current version of the grid
query in group member details lookup, since the query changes as
patron's change and is sometimes applied after the grid has already
absorbed the setQuery function.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1029601: Prevent double-clicking when submitting hold requests.

Double clicking on hold submit buttons causes multiple holds to be generated.  This adds some code to
disable the Submit button(s) after the first click, so subsequent clicks don't "work" in unintended ways.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>

KPAC Update: Remove Tumblebooks Link

GALILEO canceled Tumblebooks, so removing link.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES KPAC: Summer Reading 2019 Topics

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1630271: Add a field, change a label.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1630271 - Correct encumbrance subquery.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1630271 - Add Purchase Order Summary View

The purchase order reporting source contains several fields that are
available in the reporter but are non-functional (because they are
generated on-the-fly within user interfaces).  This view allows a
similar calculation and provides access back to the PO object as well.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP 1744386 & LP 1777184 - stat cats & stat cat entries not alphabetical

Statistical categories will be alphabetized first by library and then byt category.

The entires within each category will also be alphabetizes

fix broken holds link in My Account page

PINES Customization: Link to spine label documentation

To be added on top of Adam's spine label work.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1777677 Test Notification Method

Correcting two code typos (USER_VIEW should be VIEW_USER in Actor.pm
and language string typo in test_notification.tt2).

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

lp1777677 Security tweaks

- Refactor test notification API to check if requestor
is user,and if not, then check if requestor has
permissions to view users at target user's home ou.
- Change event_def_type references to "hook"
- Separate out sendTestEmail and sendTestSMS functions
in frontend to prevent potential misuse of functionality.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
modified:   Open-ILS/src/templates/opac/myopac/prefs.tt2
modified:   Open-ILS/src/templates/opac/myopac/prefs_notify.tt2
modified:   Open-ILS/src/templates/staff/circ/patron/t_edit.tt2
modified:   Open-ILS/web/js/ui/default/opac/test_notification.js
modified:   Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

lp1777677 Test Notification Release Notes

- Add release notes for Test Notification functionality.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
new file:   docs/RELEASE_NOTES_NEXT/Circulation/test_notification_method.adoc

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

lp1777677 Test Notification Permission & String change

- Update permission requirement to OPAC_LOGIN
- Update strings to be more end-user friendly

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
modified:   Open-ILS/src/sql/Pg/950.data.seed-values.sql
modified:   Open-ILS/src/sql/Pg/upgrade/XXXX.data.lp1777677-action-triggers-test-notification.sql
modified:   Open-ILS/src/templates/opac/myopac/prefs.tt2
modified:   Open-ILS/src/templates/opac/myopac/prefs_notify.tt2
modified:   Open-ILS/src/templates/opac/myopac/test_notification.tt2

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

lp1777677 Show test notification buttons by retrieved data

- Prevents test notification buttons from displaying when email or sms
data is input but no data exists on server.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/circ/patron/t_edit.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

lp1777677 Test Notification OPAC success prompt

- Move OPAC success prompt higher up to ensure message is
seen.
- Ensure OPAC SMS test notification doesn't send email.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/opac/myopac/prefs.tt2
modified:   Open-ILS/src/templates/opac/myopac/prefs_notify.tt2

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

lp1777677 Test Notification Method

- Create fire_test_notification subroutine to create, fire, and
return event
- Add Test Notification UI buttons to preferences and patron edit screen.
- Add Toast to inform of success or failure of sending test notification
- Add Strings to patron interface to handle ngToast notifications
- Add Test Notification to OPAC preferences UI for email
and default sms number.
- Abort Test Notification event if no user is found.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
modified:   Open-ILS/src/sql/Pg/400.schema.action_trigger.sql
modified:   Open-ILS/src/sql/Pg/950.data.seed-values.sql
new file:   Open-ILS/src/sql/Pg/upgrade/XXXX.data.lp1777677-action-triggers-test-notification.sql
modified:   Open-ILS/src/templates/opac/myopac/prefs.tt2
modified:   Open-ILS/src/templates/opac/myopac/prefs_notify.tt2
new file:   Open-ILS/src/templates/opac/myopac/test_notification.tt2
modified:   Open-ILS/src/templates/opac/parts/header.tt2
modified:   Open-ILS/src/templates/opac/parts/js.tt2
modified:   Open-ILS/src/templates/staff/circ/patron/index.tt2
modified:   Open-ILS/src/templates/staff/circ/patron/t_edit.tt2
new file:   Open-ILS/web/js/ui/default/opac/test_notification.js
modified:   Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

PINES Cust: Don't auto-open added content in staff client

Novelist and Syndetics content will still automatically open in
the OPAC but not in the staff client, which should improve client
performance.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

uncomment div to allow NoveList Select to work correctly

PINES Custom Default Spine & Pocket Label Template Code

This strips out old and unnecessary comments and code that is
no longer used after Adam's work is applied.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Custom UI Change: Date Field on Circ Screen

Forced size of custom date selector on checkout screen since
it is too small. This will probably be fixed differently in
master later, but this will help us for now.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Customization: Link to spine label documentation

To be added on top of Adam's spine label work.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1797973 - misc UI fixes where eg-org-selector expands too much

The new template for the type-ahead OU selector needs to width bound
by a parent container, this adds one where needed.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

LP1796945: More Accurate Joins in AngularJS IDL

Currently all joins of all classes are hard-coded to
inner, which is clearly sub-optimal. This branch
tries to correct this by looking at the reltype param
on links.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>

LP#1642036 - Prevent race condition in Group Member Grid

A timing condition was causing the setQuery() fnc to not
exist when called resulting in a blank group members grid.
A simple $timeout seems to address it.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

adding xact rollback & begin

Removes red notice about emailed queue complete notice on LMOR.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

Returns Activate PO ticky to LMOR

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

typo correction

add copy alert perms to LocalAdmin and LibraryManager

Adds documentation links to acqadmin menus

Adds links to appropriate PINES wiki pages for remaining Dojo Acquisition administration menus. Additionally also marks required fields on Load MARC Order Records page.

Removes checkin date column

Removes Circ ID and fixes publisher

Removes edition, due date, floating and holds count

Removed auto-populate of column options in Item Bucket, individually outlined column options in alphabetical order.

LP#1737800 - add delete action to pending patrons

This adds a way to remove a pending/staged user from
the pending users grid.

Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

removing spine label printing feature

LP#1726568: expose circ lib and owning lib fields to spine/pocket labels

This patch fleshes the item circulation library and owning library
fields so that spine/pocket labels can include the short name or
full name of the OU rather than just the ID.  As a consequence, the
following fields are now available for label templates:

* copy['call_number.owning_lib.id']
* copy['call_number.owning_lib.shortname']
* copy['call_number.owning_lib.name']
* copy['circ_lib.id']
* copy['circ_lib.shortname']
* copy['circ_lib.name']

If, for some reason, existing label templates intentionally use
copy['call_number.owning_lib'] or copy['circ_lib'] to include the numeric
ID of the OU on the label, they will need to be replaced with
copy['call_number.owning_lib.id'] or copy['circ_lib.id'] respectively.

To test
-------
[1] Apply the patch.
[2] Open the print labels window for an item and try including one
    or more of the new fields listed above; verify that the current
    value is displayed on the label preview.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

switch around order, update already existing setting

adding several other post-upgrade tasks to script

LocalAdmin already has COPY_DELETE_WARNING.override

Cat1 already has COPY_DELETE_WARNING.override

Staff already have CREATE_DUPLICATE_HOLDS perm

more typo corrections

LocalAdmin already has EMERGENCY_CLOSING

typo corrections

adding perms and settings for post-upgrade

adding refressh of reporter.materialized_simple_record

tweak parent/guardian data update

PINES Fix to Search Results Title

Fixes problem where Search Results page title was overlapping
filter boxes.

Signed-off-by: McCanna <tmccanna@georgialibraries.org>

adding file to combine rbdigital installation

adding parent/guardian data

Removes "Activate PO" ticky box on the Load MARC Order Records page.

LP#1714070 Patron parent/guardian field

Adds a new dedicated patron parent/guardian field.  This field is
editable in the patron edit interface, displays in the patron summary
side bar on the browser client, and is search-able from the patron
search interface in the browser client.

Adds patron editor "show" and "suggest" library settings.

Also adds a new library setting
'ui.patron.edit.guardian_required_for_juv' ("GUI: Juvenile account
requires parent/guardian").  When this setting is applied, a value
will be required in the patron editor when the juvenile flag is active.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

PINES Cust: Make offline interface alerts bolder

This overwrites the bootstrap CSS just for the offline
circulation page alerts boxes.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Custom: Redisplay print and email links on item record page

These were hidden in a previous patch because the functionality
wasn't there, but now that the functionality is working, adding
them back in.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1737800 - add delete action to pending patrons

This adds a way to remove a pending/staged user from
the pending users grid.

PINES Customization: Patron Summary Link to Library

Turn patron home library name on the patron summary bar into
a link to the library's contact info page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1810296: Fix selfcheck patron password setting check

Previously, the selfcheck ignored this setting if it was
set to "False", since the setting value is stored as text
and the truth test always succeeded.  Instead, explicitly
check that the setting is "True".

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

PINES Custom Hold Shelf Slip

Updated to include new preferred name at top of slip (when
present).

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

adding perms for new copy alert features

PINES CSS Customizations

Restores previous CSS customizations that got knocked out
somewhere along the way.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Customization: Alert when no hold notification options

Present an alert if no notification options are selected in
both the OPAC and web staff client.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Custom: Adjust top menu bar in OPAC for baskets

- Adjust spacing so that the basket doesn't go off the edge of the
menu bar.
- Add responsive code as well.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Custom Offline Checkout and Renew Receipts

- Correct due date to not show due time.
- Show 'Non-cataloged Item' text when there is no barcode.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Custom fix for Patron Self Registration Form DOB Validation

This moved away from master at some point. This patch brings it back
in line along with correcting a dob format checking error.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

adding new post-upgrade script

PINES Cust: Fix layout for Patron Edit Form

Readjustments to previous customizations that no longer work
properly with 3.2. Also added links to relevant documentation.

Signed-off-by: McCanna <tmccanna@georgialibraries.org>

PINES OPAC fix to My Lists

Removes incomplete IF statement that caused page not to load.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

remove post-upgrade script

PINES doesn't use LoC bib source

drop triggers first

create index only if not exists

Add fix for PG segfaults during reingest.

Also add inline docs.

fix eg version in post upgrade script

remove z3950 update for LoC

fix out-of-sync id sequence

drop reporter.copy_statistics_view for upgrade to work

LP#1672346 - Copy Statistics View

Certain third-party products such as collection development
management providers require copy statistics that are not
readily available in a single report.  This view adds those,
which will also benefit library staff reports generally.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

add pre-3.2-upgrade script

adding 3.1-3.2 upgrade script

move reingests to the end

add iOS link to OPAC footer

LP#1738249: further fix to checkout workstation

Since accs.checkout_workstation contains the workstation associated
with the initial loan (and not any subsequent renewals), use that.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1738249 - Fix checkout_workstation display issue

Addresses the issue with checkout workstation, by
attaching as a object property to the flatCopy hash.
Also makes sure the pcrud call uses combcirc.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1788260 - Break out in-house-use non-cat circulations.

Previously, all non-cataloged circulations were grouped
together, causing problems for libraries who need to
exclude in-house circulations from circ counts.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1785887 edi_order_pusher.pl sets message account

Apply the edi_message.account value when sending EDI order messages via
edi_order_pusher.pl.  This solves a problem where EDI ORDERS message
were not visible in the interface, because there was no way to complete
the permission check.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1743650: Bib vis testing needs different handling

For bib-level visibility testing, we can only use the source helper for
positive inclusion, and have to deal with LURIs on a case-by-case basis.
This is because, unlike the copy visibility cache, the LURI cache is pre-
composed in a single value for all LURIs on a record, not separate ones
for each.  This is fine, as we just need to find the effectively visible
org units and test for that subset of the relevant orgs. This commit provides
a sub to test for that, and handles LURI test composition at the perl
level rather than in the database.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1773417 Revamp item and call number tranfers

This commit attempts to achieve the goals of both simplification and
feature completeness/flexibility.  In brief, limit the number of
marking and transfer options, then have the code decide the right
action to take given the circumstances.

There are now just two "marking" actions, one at the record level,
one at the holdings level.  The holdings level mark will automatically
mark the destination as specifically as possible from the selected row,
which means either to the library or call number (vol) level.

We are also now down to two transfer options: transfer the selected
item, or transfer the selected call number.  Either option will use
as much given context as possible, then fill in any blanks with
reasonable defaults and actions.

As part of the change, a number of functions and variables are also
renamed.  This is all done for clarification, and in most cases is
due to the variable or function now being used more generally (i.e.
it is used in both the item and vol context, so it is confusing to
be named 'volume_transfer_target', etc.).

Finally, clear up a fair bit of now redundant and unused code.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1737812: Simplify holdings tranfser options

Instead of providing direct actions for transfer of library, or record, or
both, have just one volume transfer option that Does the Right Thing (tm).

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>